Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 01:22:21PM +0100, Jakub Hrozek wrote: > > >Thank you. > > > > > >Replace this: > > > > > >+ERROR("Higher version of database is expected!\n"); \ > > >+SYSDB_VERSION_ERROR_HINT; \ > > >+ERROR("In this case, you could also try running SSSD, " \ > > >+

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 08:45:35AM +0100, Ondrej Kos wrote: > On 11/16/2012 04:40 PM, Jan Cholasta wrote: > >On 16.11.2012 15:25, Ondrej Kos wrote: > >>On 11/15/2012 03:03 PM, Jan Cholasta wrote: > >>>On 14.11.2012 16:20, Ondrej Kos wrote: > On 11/14/2012 03:38 PM, Simo Sorce wrote: > >On W

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-18 Thread Ondrej Kos
On 11/16/2012 04:40 PM, Jan Cholasta wrote: On 16.11.2012 15:25, Ondrej Kos wrote: On 11/15/2012 03:03 PM, Jan Cholasta wrote: On 14.11.2012 16:20, Ondrej Kos wrote: On 11/14/2012 03:38 PM, Simo Sorce wrote: On Wed, 2012-11-14 at 15:18 +0100, Jan Cholasta wrote: Just one more nitpick: SSS_D

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-16 Thread Jan Cholasta
On 16.11.2012 15:25, Ondrej Kos wrote: On 11/15/2012 03:03 PM, Jan Cholasta wrote: On 14.11.2012 16:20, Ondrej Kos wrote: On 11/14/2012 03:38 PM, Simo Sorce wrote: On Wed, 2012-11-14 at 15:18 +0100, Jan Cholasta wrote: Just one more nitpick: SSS_DB_CHECK_PTS and sss_db_version_check are used

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-16 Thread Ondrej Kos
On 11/15/2012 03:03 PM, Jan Cholasta wrote: On 14.11.2012 16:20, Ondrej Kos wrote: On 11/14/2012 03:38 PM, Simo Sorce wrote: On Wed, 2012-11-14 at 15:18 +0100, Jan Cholasta wrote: Just one more nitpick: SSS_DB_CHECK_PTS and sss_db_version_check are used only in sysdb.c, so there is no reason

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-15 Thread Jan Cholasta
On 14.11.2012 16:20, Ondrej Kos wrote: On 11/14/2012 03:38 PM, Simo Sorce wrote: On Wed, 2012-11-14 at 15:18 +0100, Jan Cholasta wrote: Just one more nitpick: SSS_DB_CHECK_PTS and sss_db_version_check are used only in sysdb.c, so there is no reason to have them defined publicly in util.h+util.

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-14 Thread Ondrej Kos
On 11/14/2012 03:38 PM, Simo Sorce wrote: On Wed, 2012-11-14 at 15:18 +0100, Jan Cholasta wrote: Just one more nitpick: SSS_DB_CHECK_PTS and sss_db_version_check are used only in sysdb.c, so there is no reason to have them defined publicly in util.h+util.c. Move them both to sysdb.c please (you

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-14 Thread Simo Sorce
On Wed, 2012-11-14 at 15:18 +0100, Jan Cholasta wrote: > > Just one more nitpick: SSS_DB_CHECK_PTS and sss_db_version_check are > used only in sysdb.c, so there is no reason to have them defined > publicly in util.h+util.c. Move them both to sysdb.c please (you > might > also want to rename the

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-14 Thread Jan Cholasta
On 14.11.2012 14:03, Ondrej Kos wrote: On 11/14/2012 11:53 AM, Jan Cholasta wrote: On 13.11.2012 15:41, Ondrej Kos wrote: On 11/12/2012 01:14 PM, Jan Cholasta wrote: On 9.11.2012 13:24, Ondrej Kos wrote: On 11/08/2012 07:01 PM, Jan Cholasta wrote: Hi, On 8.11.2012 15:05, Ondrej Kos wrote:

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-14 Thread Ondrej Kos
On 11/14/2012 11:53 AM, Jan Cholasta wrote: On 13.11.2012 15:41, Ondrej Kos wrote: On 11/12/2012 01:14 PM, Jan Cholasta wrote: On 9.11.2012 13:24, Ondrej Kos wrote: On 11/08/2012 07:01 PM, Jan Cholasta wrote: Hi, On 8.11.2012 15:05, Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/158

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-14 Thread Jan Cholasta
On 13.11.2012 15:41, Ondrej Kos wrote: On 11/12/2012 01:14 PM, Jan Cholasta wrote: On 9.11.2012 13:24, Ondrej Kos wrote: On 11/08/2012 07:01 PM, Jan Cholasta wrote: Hi, On 8.11.2012 15:05, Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/1589 patch is attached O. 1) I think monito

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-13 Thread Ondrej Kos
On 11/12/2012 01:14 PM, Jan Cholasta wrote: On 9.11.2012 13:24, Ondrej Kos wrote: On 11/08/2012 07:01 PM, Jan Cholasta wrote: Hi, On 8.11.2012 15:05, Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/1589 patch is attached O. 1) I think monitor and responders should use a different

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-12 Thread Jakub Hrozek
On Mon, Nov 12, 2012 at 01:14:22PM +0100, Jan Cholasta wrote: > Please add src/util/util.c to po/POTFILES.in, so that gettext can > pick up the error messages you have added for translation. Nice catch, but this really sounds like something that should be automated or at least checked by buildsyst

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-12 Thread Jan Cholasta
On 9.11.2012 13:24, Ondrej Kos wrote: On 11/08/2012 07:01 PM, Jan Cholasta wrote: Hi, On 8.11.2012 15:05, Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/1589 patch is attached O. 1) I think monitor and responders should use a different error message, excluding "If greater version

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-09 Thread Ondrej Kos
On 11/08/2012 07:01 PM, Jan Cholasta wrote: Hi, On 8.11.2012 15:05, Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/1589 patch is attached O. 1) I think monitor and responders should use a different error message, excluding "If greater version is expected, run SSSD ...". Telling use

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-08 Thread Jan Cholasta
Hi, On 8.11.2012 15:05, Ondrej Kos wrote: https://fedorahosted.org/sssd/ticket/1589 patch is attached O. 1) I think monitor and responders should use a different error message, excluding "If greater version is expected, run SSSD ...". Telling users to run SSSD when they in fact have it ru

[SSSD] [PATCH] Display more information on DB version crash

2012-11-08 Thread Ondrej Kos
https://fedorahosted.org/sssd/ticket/1589 patch is attached O. -- Ondrej Kos Associate Software Engineer Identity Management Red Hat Czech phone: +420-532-294-558 cell: +420-736-417-909 ext: 82-62558 loc: 1013 Brno 1 office irc: okos @ #brno From 66285281354a3d49f9f9f526472bba479b90694a