[SSSD] [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not available

2013-09-17 Thread Sumit Bose
Hi, I found this on a system where systemd-devel was not installed. Since we already know that systemd is available at this stage of the configure run I wonder if AC_MSG_NOTICE is ok or if AC_MSG_ERROR asking to install systemd-devel would be better? bye, Sumit From

Re: [SSSD] [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not available

2013-09-17 Thread Jakub Hrozek
On Tue, Sep 17, 2013 at 01:00:07PM +0200, Sumit Bose wrote: Hi, I found this on a system where systemd-devel was not installed. Since we already know that systemd is available at this stage of the configure run I wonder if AC_MSG_NOTICE is ok or if AC_MSG_ERROR asking to install

Re: [SSSD] [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not available

2013-09-17 Thread Pavel Březina
On 09/17/2013 01:26 PM, Jakub Hrozek wrote: On Tue, Sep 17, 2013 at 01:00:07PM +0200, Sumit Bose wrote: Hi, I found this on a system where systemd-devel was not installed. Since we already know that systemd is available at this stage of the configure run I wonder if AC_MSG_NOTICE is ok or if

Re: [SSSD] [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not available

2013-09-17 Thread Jakub Hrozek
On Tue, Sep 17, 2013 at 03:23:48PM +0200, Pavel Březina wrote: But currently there is no way to enable/disable the support without having the right library installed. Do you think there would be value in a switch like this or the autodetection is OK? I don't see a point to disable it on

Re: [SSSD] [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not available

2013-09-17 Thread Jakub Hrozek
On Tue, Sep 17, 2013 at 03:23:48PM +0200, Pavel Březina wrote: ACK to this patch, we can decide about the option later. Ack from me as well. Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org