Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-07-18 Thread Jakub Hrozek
On Wed, Jul 17, 2013 at 07:17:13PM +0200, Ondrej Kos wrote: On 07/17/2013 06:47 PM, Jakub Hrozek wrote: On Wed, Jul 17, 2013 at 02:04:16PM +0200, Ondrej Kos wrote: On 07/16/2013 08:10 PM, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 11:15:09PM +0200, Jakub Hrozek wrote: On Fri, Jun 28, 2013 at

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-07-18 Thread Jakub Hrozek
On Thu, Jul 18, 2013 at 04:04:08PM +0200, Jakub Hrozek wrote: On Wed, Jul 17, 2013 at 07:17:13PM +0200, Ondrej Kos wrote: On 07/17/2013 06:47 PM, Jakub Hrozek wrote: On Wed, Jul 17, 2013 at 02:04:16PM +0200, Ondrej Kos wrote: On 07/16/2013 08:10 PM, Jakub Hrozek wrote: On Tue, Jul 09,

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-07-17 Thread Ondrej Kos
On 07/16/2013 08:10 PM, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 11:15:09PM +0200, Jakub Hrozek wrote: On Fri, Jun 28, 2013 at 02:23:01PM +0200, Lukas Slebodnik wrote: On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in faultly read DBUS message,

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-07-17 Thread Jakub Hrozek
On Wed, Jul 17, 2013 at 02:04:16PM +0200, Ondrej Kos wrote: On 07/16/2013 08:10 PM, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 11:15:09PM +0200, Jakub Hrozek wrote: On Fri, Jun 28, 2013 at 02:23:01PM +0200, Lukas Slebodnik wrote: On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-07-17 Thread Ondrej Kos
On 07/17/2013 06:47 PM, Jakub Hrozek wrote: On Wed, Jul 17, 2013 at 02:04:16PM +0200, Ondrej Kos wrote: On 07/16/2013 08:10 PM, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 11:15:09PM +0200, Jakub Hrozek wrote: On Fri, Jun 28, 2013 at 02:23:01PM +0200, Lukas Slebodnik wrote: On (24/06/13

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-07-16 Thread Jakub Hrozek
On Tue, Jul 09, 2013 at 11:15:09PM +0200, Jakub Hrozek wrote: On Fri, Jun 28, 2013 at 02:23:01PM +0200, Lukas Slebodnik wrote: On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string.

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-07-09 Thread Jakub Hrozek
On Fri, Jun 28, 2013 at 02:23:01PM +0200, Lukas Slebodnik wrote: On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string. When password is empty, it passes 0 as length, which is

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-06-28 Thread Lukas Slebodnik
On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string. When password is empty, it passes 0 as length, which is misinterpreted, and the function tries to determine the length of string by

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-06-27 Thread Ondrej Kos
On 06/25/2013 02:55 PM, Lukas Slebodnik wrote: I tried this patch and you did not reach krb5 authentication in krb5_child, but reason is: #[krb5_auth_send] (0x0020): Wrong authtok type for user [usersssd01]. # Expected [1], got [0] So it failed in sssd_be I tried next

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-06-27 Thread Pavel Březina
On 06/25/2013 02:55 PM, Lukas Slebodnik wrote: On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string. When password is empty, it passes 0 as length, which is misinterpreted, and the

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-06-27 Thread Ondrej Kos
On 06/27/2013 01:17 PM, Pavel Březina wrote: On 06/25/2013 02:55 PM, Lukas Slebodnik wrote: On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string. When password is empty, it passes 0

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-06-27 Thread Pavel Březina
On 06/27/2013 01:39 PM, Sumit Bose wrote: On Thu, Jun 27, 2013 at 01:32:59PM +0200, Ondrej Kos wrote: On 06/27/2013 01:17 PM, Pavel Březina wrote: On 06/25/2013 02:55 PM, Lukas Slebodnik wrote: On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in

Re: [SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-06-25 Thread Lukas Slebodnik
On (24/06/13 17:04), Ondrej Kos wrote: The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string. When password is empty, it passes 0 as length, which is misinterpreted, and the function tries to determine the length of string by

[SSSD] [PATCH] Do not try to set password when authtok_length is zero

2013-06-24 Thread Ondrej Kos
The problem here wasn't in returned error code, but in faultly read DBUS message, due to condition in sss_authtok_set_string. When password is empty, it passes 0 as length, which is misinterpreted, and the function tries to determine the length of string by itself, reaching over boundaries of