Re: [SSSD] [PATCH] Don't test for NULL in nscd config check

2013-06-10 Thread Jakub Hrozek
On Mon, Jun 10, 2013 at 11:37:39AM +0200, Jakub Hrozek wrote: > On Mon, Jun 10, 2013 at 10:05:25AM +0200, Ondrej Kos wrote: > > On 06/09/2013 01:36 PM, Jakub Hrozek wrote: > > >>entry, service, enabled are "incremented version of" pointer line, which > > >>is > > >>>not NULL. > > >>> > > >>>ACK >

Re: [SSSD] [PATCH] Don't test for NULL in nscd config check

2013-06-10 Thread Jakub Hrozek
On Mon, Jun 10, 2013 at 10:05:25AM +0200, Ondrej Kos wrote: > On 06/09/2013 01:36 PM, Jakub Hrozek wrote: > >>entry, service, enabled are "incremented version of" pointer line, which is > >>>not NULL. > >>> > >>>ACK > >>> > >>>LS > >Can we also remove the assignments of entry,service and enabled to

Re: [SSSD] [PATCH] Don't test for NULL in nscd config check

2013-06-10 Thread Ondrej Kos
On 06/09/2013 01:36 PM, Jakub Hrozek wrote: entry, service, enabled are "incremented version of" pointer line, which is >not NULL. > >ACK > >LS Can we also remove the assignments of entry,service and enabled to NULL now since they will always be non-NULL in the while() iteration? Sure, new pat

Re: [SSSD] [PATCH] Don't test for NULL in nscd config check

2013-06-09 Thread Jakub Hrozek
On Fri, Jun 07, 2013 at 07:03:25PM +0200, Lukas Slebodnik wrote: > On (07/06/13 14:38), Ondrej Kos wrote: > >Hi, > > > >Attached patch fixes the following issue: > >https://fedorahosted.org/sssd/ticket/1971 > > > >This is coverity bug, CIDs: 11851,11852,11853 > > > >I tested this with NSCD configur

Re: [SSSD] [PATCH] Don't test for NULL in nscd config check

2013-06-07 Thread Lukas Slebodnik
On (07/06/13 14:38), Ondrej Kos wrote: >Hi, > >Attached patch fixes the following issue: >https://fedorahosted.org/sssd/ticket/1971 > >This is coverity bug, CIDs: 11851,11852,11853 > >I tested this with NSCD configuration file malformed in various ways. > >The first thing is, NSCD won't even start,

[SSSD] [PATCH] Don't test for NULL in nscd config check

2013-06-07 Thread Ondrej Kos
Hi, Attached patch fixes the following issue: https://fedorahosted.org/sssd/ticket/1971 This is coverity bug, CIDs: 11851,11852,11853 I tested this with NSCD configuration file malformed in various ways. The first thing is, NSCD won't even start, when nscd.conf doesn't meet the specifications