Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 05:03 AM, Jakub Hrozek wrote: > On 10/06/2009 08:29 PM, Stephen Gallagher wrote: >> Nack after all. Jenny noticed that there are some places where the >> returned error code should be nonzero and it is not. > >> Please fix these up and r

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-12 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2009 08:29 PM, Stephen Gallagher wrote: > Nack after all. Jenny noticed that there are some places where the > returned error code should be nonzero and it is not. > > Please fix these up and resubmit. I looked at the test cases and I think

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-07 Thread Jenny Galipeau
Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/06/2009 07:40 AM, Stephen Gallagher wrote: > >> On 10/06/2009 06:32 AM, Jakub Hrozek wrote: >> >>> On 10/05/2009 07:43 PM, Stephen Gallagher wrote: >>> Replied to the wrong patch earlier...

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2009 07:40 AM, Stephen Gallagher wrote: > On 10/06/2009 06:32 AM, Jakub Hrozek wrote: >> On 10/05/2009 07:43 PM, Stephen Gallagher wrote: >>> Replied to the wrong patch earlier... > >>> Nack. >>> sss_getpwnam_done() and friends should return

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2009 06:32 AM, Jakub Hrozek wrote: > On 10/05/2009 07:43 PM, Stephen Gallagher wrote: >> Replied to the wrong patch earlier... > >> Nack. >> sss_getpwnam_done() and friends should return EIO if the sysdb replies >> with more than one result,

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-06 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2009 07:43 PM, Stephen Gallagher wrote: > Replied to the wrong patch earlier... > > Nack. > sss_getpwnam_done() and friends should return EIO if the sysdb replies > with more than one result, I think. EINVAL implies that the fault was > with

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2009 12:13 PM, Jakub Hrozek wrote: > On 10/05/2009 05:49 PM, Jakub Hrozek wrote: >> Add getpwnam, getgrnam sync versions > >> Fix ticket #164: Groupnames in non-local domains >> Fix ticket #100: Error Message Modifying a user that doesn't Exi

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-05 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2009 05:49 PM, Jakub Hrozek wrote: > Add getpwnam, getgrnam sync versions > > Fix ticket #164: Groupnames in non-local domains > Fix ticket #100: Error Message Modifying a user that doesn't Exist > Fix ticket #214: incorrect error message whe

[SSSD] [PATCH] Fix error messages in tools

2009-10-05 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Add getpwnam, getgrnam sync versions Fix ticket #164: Groupnames in non-local domains Fix ticket #100: Error Message Modifying a user that doesn't Exist Fix ticket #214: incorrect error message when MPG already exists Fix ticket #188: Deleting and mod