Re: [SSSD] [PATCH] Fix segfault in AD Subdomains Module

2013-05-15 Thread Jakub Hrozek
On Wed, May 15, 2013 at 02:05:42PM +0200, steve wrote: > On 15/05/13 11:50, Jakub Hrozek wrote: > >On Wed, May 15, 2013 at 11:34:19AM +0200, Lukas Slebodnik wrote: > >>On (15/05/13 11:19), Jakub Hrozek wrote: > >>>On Wed, May 15, 2013 at 10:17:02AM +0200, Lukas Slebodnik wrote: > ehlo, > >

Re: [SSSD] [PATCH] Fix segfault in AD Subdomains Module

2013-05-15 Thread steve
On 15/05/13 11:50, Jakub Hrozek wrote: On Wed, May 15, 2013 at 11:34:19AM +0200, Lukas Slebodnik wrote: On (15/05/13 11:19), Jakub Hrozek wrote: On Wed, May 15, 2013 at 10:17:02AM +0200, Lukas Slebodnik wrote: ehlo, In function ad_subdomains_get_netlogon_done: If variable "reply_count" is zer

Re: [SSSD] [PATCH] Fix segfault in AD Subdomains Module

2013-05-15 Thread Jakub Hrozek
On Wed, May 15, 2013 at 11:34:19AM +0200, Lukas Slebodnik wrote: > On (15/05/13 11:19), Jakub Hrozek wrote: > >On Wed, May 15, 2013 at 10:17:02AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> In function ad_subdomains_get_netlogon_done: > >> If variable "reply_count" is zero then variable "re

Re: [SSSD] [PATCH] Fix segfault in AD Subdomains Module

2013-05-15 Thread Lukas Slebodnik
On (15/05/13 11:19), Jakub Hrozek wrote: >On Wed, May 15, 2013 at 10:17:02AM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> In function ad_subdomains_get_netlogon_done: >> If variable "reply_count" is zero then variable "reply" will not be >> initialized. Therefore we should not continue. >> >> I a

Re: [SSSD] [PATCH] Fix segfault in AD Subdomains Module

2013-05-15 Thread Jakub Hrozek
On Wed, May 15, 2013 at 10:17:02AM +0200, Lukas Slebodnik wrote: > ehlo, > > In function ad_subdomains_get_netlogon_done: > If variable "reply_count" is zero then variable "reply" will not be > initialized. Therefore we should not continue. > > I am not sure about return code. > > Patch is attac

[SSSD] [PATCH] Fix segfault in AD Subdomains Module

2013-05-15 Thread Lukas Slebodnik
ehlo, In function ad_subdomains_get_netlogon_done: If variable "reply_count" is zero then variable "reply" will not be initialized. Therefore we should not continue. I am not sure about return code. Patch is attached. LS >From b15e1a6b664201493ec0288a9c8e4ec5b2983dbc Mon Sep 17 00:00:00 2001 Fr