Re: [SSSD] [PATCH] Include external headers with #include

2013-11-04 Thread Jakub Hrozek
On Fri, Nov 01, 2013 at 11:21:38AM +0100, Jakub Hrozek wrote: > On Fri, Nov 01, 2013 at 11:18:47AM +0100, Jakub Hrozek wrote: > > On Fri, Nov 01, 2013 at 11:05:33AM +0100, Pavel Reichl wrote: > > > On Thu, 2013-10-31 at 19:53 +0100, Jakub Hrozek wrote: > > > > On Thu, Oct 31, 2013 at 10:53:40AM +01

Re: [SSSD] [PATCH] Include external headers with #include

2013-11-01 Thread Jakub Hrozek
On Fri, Nov 01, 2013 at 11:18:47AM +0100, Jakub Hrozek wrote: > On Fri, Nov 01, 2013 at 11:05:33AM +0100, Pavel Reichl wrote: > > On Thu, 2013-10-31 at 19:53 +0100, Jakub Hrozek wrote: > > > On Thu, Oct 31, 2013 at 10:53:40AM +0100, Lukas Slebodnik wrote: > > > > On (22/10/13 16:38), Pavel Reichl w

Re: [SSSD] [PATCH] Include external headers with #include

2013-11-01 Thread Jakub Hrozek
On Fri, Nov 01, 2013 at 11:05:33AM +0100, Pavel Reichl wrote: > On Thu, 2013-10-31 at 19:53 +0100, Jakub Hrozek wrote: > > On Thu, Oct 31, 2013 at 10:53:40AM +0100, Lukas Slebodnik wrote: > > > On (22/10/13 16:38), Pavel Reichl wrote: > > > >On Tue, 2013-10-22 at 15:10 +0200, Lukas Slebodnik wrote:

Re: [SSSD] [PATCH] Include external headers with #include

2013-11-01 Thread Pavel Reichl
On Thu, 2013-10-31 at 19:53 +0100, Jakub Hrozek wrote: > On Thu, Oct 31, 2013 at 10:53:40AM +0100, Lukas Slebodnik wrote: > > On (22/10/13 16:38), Pavel Reichl wrote: > > >On Tue, 2013-10-22 at 15:10 +0200, Lukas Slebodnik wrote: > > >> On (22/10/13 10:41), Jakub Hrozek wrote: > > >> >On Tue, Oct 2

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-31 Thread Jakub Hrozek
On Thu, Oct 31, 2013 at 10:53:40AM +0100, Lukas Slebodnik wrote: > On (22/10/13 16:38), Pavel Reichl wrote: > >On Tue, 2013-10-22 at 15:10 +0200, Lukas Slebodnik wrote: > >> On (22/10/13 10:41), Jakub Hrozek wrote: > >> >On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: > >> >> On (2

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-31 Thread Lukas Slebodnik
On (22/10/13 16:38), Pavel Reichl wrote: >On Tue, 2013-10-22 at 15:10 +0200, Lukas Slebodnik wrote: >> On (22/10/13 10:41), Jakub Hrozek wrote: >> >On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: >> >> On (22/10/13 09:17), Jakub Hrozek wrote: >> >> >On Mon, Oct 21, 2013 at 08:17:00

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-31 Thread Pavel Březina
On 10/22/2013 04:38 PM, Pavel Reichl wrote: On Tue, 2013-10-22 at 15:10 +0200, Lukas Slebodnik wrote: On (22/10/13 10:41), Jakub Hrozek wrote: On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: On (22/10/13 09:17), Jakub Hrozek wrote: On Mon, Oct 21, 2013 at 08:17:00AM -0400, St

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-31 Thread Pavel Březina
On 10/31/2013 10:44 AM, Lukas Slebodnik wrote: On (31/10/13 10:26), Pavel Březina wrote: On 10/21/2013 11:28 AM, Jakub Hrozek wrote: Attached is a style patch. Feel free to ack or nack, it's just a readability improvement. This patch no longer applies to master. Patch cannot be applied on m

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-31 Thread Lukas Slebodnik
On (31/10/13 10:26), Pavel Březina wrote: >On 10/21/2013 11:28 AM, Jakub Hrozek wrote: >>Attached is a style patch. Feel free to ack or nack, it's just a >>readability improvement. > >This patch no longer applies to master. > Patch cannot be applied on master, because patch is already in master. ht

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-31 Thread Pavel Březina
On 10/21/2013 11:28 AM, Jakub Hrozek wrote: Attached is a style patch. Feel free to ack or nack, it's just a readability improvement. This patch no longer applies to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Pavel Reichl
On Tue, 2013-10-22 at 15:10 +0200, Lukas Slebodnik wrote: > On (22/10/13 10:41), Jakub Hrozek wrote: > >On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: > >> On (22/10/13 09:17), Jakub Hrozek wrote: > >> >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: > >> >> ---

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Lukas Slebodnik
On (22/10/13 10:41), Jakub Hrozek wrote: >On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: >> On (22/10/13 09:17), Jakub Hrozek wrote: >> >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> >> Hash: SHA1 >> >> >> >> On 10/

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Jakub Hrozek
On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote: > On (22/10/13 09:17), Jakub Hrozek wrote: > >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> On 10/21/2013 05:28 AM, Jakub Hrozek wrote: > >> > Att

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Lukas Slebodnik
On (22/10/13 09:17), Jakub Hrozek wrote: >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 10/21/2013 05:28 AM, Jakub Hrozek wrote: >> > Attached is a style patch. Feel free to ack or nack, it's just a >> > readability

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-22 Thread Jakub Hrozek
On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/21/2013 05:28 AM, Jakub Hrozek wrote: > > Attached is a style patch. Feel free to ack or nack, it's just a > > readability improvement. > > > > Ack. I agree, out-of-tre

Re: [SSSD] [PATCH] Include external headers with #include

2013-10-21 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2013 05:28 AM, Jakub Hrozek wrote: > Attached is a style patch. Feel free to ack or nack, it's just a > readability improvement. > Ack. I agree, out-of-tree headers should be using <> A fair number of these are pointing at the ding-libs he

[SSSD] [PATCH] Include external headers with #include

2013-10-21 Thread Jakub Hrozek
Attached is a style patch. Feel free to ack or nack, it's just a readability improvement. >From d25f89e20417db947dc3c692411683b77b4ee7d7 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 2 Oct 2013 11:53:33 +0200 Subject: [PATCH] Include external headers with #include I find it more readabl