Re: [SSSD] [PATCH] KRB5: Refactor cc_*_check_existing

2013-08-22 Thread Jakub Hrozek
On Thu, Aug 22, 2013 at 07:27:07PM +0200, Jakub Hrozek wrote: > On Thu, Aug 22, 2013 at 10:18:36AM -0400, Stephen Gallagher wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 08/22/2013 10:11 AM, Stephen Gallagher wrote: > > > On 08/15/2013 11:50 AM, Stephen Gallagher wrote: >

Re: [SSSD] [PATCH] KRB5: Refactor cc_*_check_existing

2013-08-22 Thread Jakub Hrozek
On Thu, Aug 22, 2013 at 10:18:36AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/22/2013 10:11 AM, Stephen Gallagher wrote: > > On 08/15/2013 11:50 AM, Stephen Gallagher wrote: > >> There was duplicated code in cc_file_check_existing() and in > >> cc_

Re: [SSSD] [PATCH] KRB5: Refactor cc_*_check_existing

2013-08-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/22/2013 10:11 AM, Stephen Gallagher wrote: > On 08/15/2013 11:50 AM, Stephen Gallagher wrote: >> There was duplicated code in cc_file_check_existing() and in >> cc_dir_check_existing(). I pulled them into the same function. > >> There are two c

Re: [SSSD] [PATCH] KRB5: Refactor cc_*_check_existing

2013-08-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/15/2013 11:50 AM, Stephen Gallagher wrote: > There was duplicated code in cc_file_check_existing() and in > cc_dir_check_existing(). I pulled them into the same function. > > There are two changes made to the original code here: 1) Fixes a > us

Re: [SSSD] [PATCH] KRB5: Refactor cc_*_check_existing

2013-08-16 Thread Sumit Bose
On Thu, Aug 15, 2013 at 11:50:14AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > There was duplicated code in cc_file_check_existing() and in > cc_dir_check_existing(). I pulled them into the same function. > > There are two changes made to the original cod

Re: [SSSD] [PATCH] KRB5: Refactor cc_*_check_existing

2013-08-15 Thread Simo Sorce
On Thu, 2013-08-15 at 11:50 -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > There was duplicated code in cc_file_check_existing() and in > cc_dir_check_existing(). I pulled them into the same function. > > There are two changes made to the original code here:

[SSSD] [PATCH] KRB5: Refactor cc_*_check_existing

2013-08-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There was duplicated code in cc_file_check_existing() and in cc_dir_check_existing(). I pulled them into the same function. There are two changes made to the original code here: 1) Fixes a use-after-free bug in cc_file_check_existing(). In the origina