Re: [SSSD] [PATCH] Make config_file_version a hidden setting in SSSDConfig API

2009-11-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/2009 10:09 AM, Simo Sorce wrote: > On Tue, 2009-11-03 at 10:05 -0500, Stephen Gallagher wrote: >> On 11/03/2009 09:37 AM, Simo Sorce wrote: >>> On Thu, 2009-10-29 at 14:19 -0400, Stephen Gallagher wrote: The config_file_version should nev

Re: [SSSD] [PATCH] Make config_file_version a hidden setting in SSSDConfig API

2009-11-03 Thread Simo Sorce
On Tue, 2009-11-03 at 10:05 -0500, Stephen Gallagher wrote: > On 11/03/2009 09:37 AM, Simo Sorce wrote: > > On Thu, 2009-10-29 at 14:19 -0400, Stephen Gallagher wrote: > >> The config_file_version should never be changed by the API, so we > >> will hide the option inside the SSSDConfig API and remo

Re: [SSSD] [PATCH] Make config_file_version a hidden setting in SSSDConfig API

2009-11-03 Thread Stephen Gallagher
On 11/03/2009 09:37 AM, Simo Sorce wrote: > On Thu, 2009-10-29 at 14:19 -0400, Stephen Gallagher wrote: >> The config_file_version should never be changed by the API, so we >> will hide the option inside the SSSDConfig API and remove it from >> the schema. > > Patch is ok, but nack because it miss

Re: [SSSD] [PATCH] Make config_file_version a hidden setting in SSSDConfig API

2009-11-03 Thread Simo Sorce
On Thu, 2009-10-29 at 14:19 -0400, Stephen Gallagher wrote: > The config_file_version should never be changed by the API, so we > will hide the option inside the SSSDConfig API and remove it from > the schema. Patch is ok, but nack because it misses to bail out if the config version in the input f

[SSSD] [PATCH] Make config_file_version a hidden setting in SSSDConfig API

2009-10-29 Thread Stephen Gallagher
The config_file_version should never be changed by the API, so we will hide the option inside the SSSDConfig API and remove it from the schema. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/prom