Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/13/2009 10:31 AM, Simo Sorce wrote: With this patch all the backend providers can share the same offline status. This means composite backends like what AD or IPA will be that use a mix of ldap and krb can share the offline status for both

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 07:48 -0400, Stephen Gallagher wrote: Just a nitpick, but why did you replace sbus_conn_send_reply() in be_check_online with sbus_get_connection and dbus_connection_send()? They are functionally identical. (except that sbus_conn_send_reply() can get the connection in one

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Sumit Bose
On Mon, Sep 14, 2009 at 11:30:44AM -0400, Simo Sorce wrote: On Mon, 2009-09-14 at 07:48 -0400, Stephen Gallagher wrote: Just a nitpick, but why did you replace sbus_conn_send_reply() in be_check_online with sbus_get_connection and dbus_connection_send()? They are functionally identical.

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 18:10 +0200, Sumit Bose wrote: I agree, this patch is a good starting point and we can add fine tuning later. ACK. pushed Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list

[SSSD] [PATCH] Make offline status backend global

2009-09-13 Thread Simo Sorce
With this patch all the backend providers can share the same offline status. This means composite backends like what AD or IPA will be that use a mix of ldap and krb can share the offline status for both protocols. A further extension might allow to have per protocol online/offline status, that