Re: [SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-04 Thread Stephen Gallagher
On Fri, 2012-05-04 at 13:37 -0400, Stephen Gallagher wrote: > On Fri, 2012-05-04 at 13:34 -0400, Stephen Gallagher wrote: > > On Fri, 2012-05-04 at 09:02 +0200, Jan Zelený wrote: > > > > > > Nack: you're still deleting the pam_pwd_expiration_warning option from > > > > sssd-ldap.conf and you need

Re: [SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-04 Thread Stephen Gallagher
On Fri, 2012-05-04 at 13:34 -0400, Stephen Gallagher wrote: > On Fri, 2012-05-04 at 09:02 +0200, Jan Zelený wrote: > > > > Nack: you're still deleting the pam_pwd_expiration_warning option from > > > sssd-ldap.conf and you need to update the commit message. Otherwise, > > > looks good. > > > > Th

Re: [SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-04 Thread Stephen Gallagher
On Fri, 2012-05-04 at 09:02 +0200, Jan Zelený wrote: > > Nack: you're still deleting the pam_pwd_expiration_warning option from > > sssd-ldap.conf and you need to update the commit message. Otherwise, > > looks good. > > Thanks for noticing, I missed that completely. All done. Ack signature.a

Re: [SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-04 Thread Jan Zelený
> On Thu, 2012-05-03 at 13:08 +0200, Jan Zelený wrote: > > > On Tue, 2012-05-01 at 19:16 +0200, Jan Zeleny wrote: > > > > - rename the option to pwd_expiration_warning > > > > - move the option from PAM responder to domains > > > > - if pwd_expiration_warning == 0, don't apply the filter at all > >

Re: [SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-03 Thread Stephen Gallagher
On Thu, 2012-05-03 at 13:08 +0200, Jan Zelený wrote: > > On Tue, 2012-05-01 at 19:16 +0200, Jan Zeleny wrote: > > > - rename the option to pwd_expiration_warning > > > - move the option from PAM responder to domains > > > - if pwd_expiration_warning == 0, don't apply the filter at all > > > - defau

Re: [SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-03 Thread Jan Zelený
> On Tue, 2012-05-01 at 19:16 +0200, Jan Zeleny wrote: > > - rename the option to pwd_expiration_warning > > - move the option from PAM responder to domains > > - if pwd_expiration_warning == 0, don't apply the filter at all > > - default value for Kerberos: 7 days > > - default value for LDAP: don

Re: [SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-01 Thread Stephen Gallagher
On Tue, 2012-05-01 at 19:16 +0200, Jan Zeleny wrote: > - rename the option to pwd_expiration_warning > - move the option from PAM responder to domains > - if pwd_expiration_warning == 0, don't apply the filter at all > - default value for Kerberos: 7 days > - default value for LDAP: don't apply the

[SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

2012-05-01 Thread Jan Zeleny
- rename the option to pwd_expiration_warning - move the option from PAM responder to domains - if pwd_expiration_warning == 0, don't apply the filter at all - default value for Kerberos: 7 days - default value for LDAP: don't apply the filter Technical note: default value when creating the domain