Re: [SSSD] [PATCH] Never remove gecos from the sysdb cache

2011-04-13 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/2011 04:48 PM, Simo Sorce wrote: > On Tue, 12 Apr 2011 12:54:54 -0400 > Stephen Gallagher wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Now that gecos can come from either the 'gecos' or 'cn' attributes, >> we need to en

Re: [SSSD] [PATCH] Never remove gecos from the sysdb cache

2011-04-12 Thread Simo Sorce
On Tue, 12 Apr 2011 12:54:54 -0400 Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Now that gecos can come from either the 'gecos' or 'cn' attributes, > we need to ensure that we never remove it from the cache. > > We were being too greedy with our removal code. I

Re: [SSSD] [PATCH] Never remove gecos from the sysdb cache

2011-04-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/2011 03:41 PM, Sumit Bose wrote: > On Tue, Apr 12, 2011 at 12:54:54PM -0400, Stephen Gallagher wrote: > Now that gecos can come from either the 'gecos' or 'cn' attributes, > we need to ensure that we never remove it from the cache. > > We wer

Re: [SSSD] [PATCH] Never remove gecos from the sysdb cache

2011-04-12 Thread Sumit Bose
On Tue, Apr 12, 2011 at 12:54:54PM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Now that gecos can come from either the 'gecos' or 'cn' attributes, > we need to ensure that we never remove it from the cache. > > We were being too greedy with our removal co

[SSSD] [PATCH] Never remove gecos from the sysdb cache

2011-04-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Now that gecos can come from either the 'gecos' or 'cn' attributes, we need to ensure that we never remove it from the cache. We were being too greedy with our removal code. It purges from the sysdb cache any attributes that were requested from LDAP b