Re: [SSSD] [PATCH] Refactoring: remove duplicated code in nss responder

2013-04-21 Thread Jakub Hrozek
On Sun, 2013-04-21 at 11:21 +0200, Jakub Hrozek wrote: > On Fri, 2013-04-19 at 21:48 +0200, Sumit Bose wrote: > > On Fri, Apr 19, 2013 at 07:47:09PM +0200, Jakub Hrozek wrote: > > > On Mon, Apr 15, 2013 at 10:34:07PM +0200, Sumit Bose wrote: > > > > Hi, > > > > > > > > while working on adding new

Re: [SSSD] [PATCH] Refactoring: remove duplicated code in nss responder

2013-04-21 Thread Jakub Hrozek
On Fri, 2013-04-19 at 21:48 +0200, Sumit Bose wrote: > On Fri, Apr 19, 2013 at 07:47:09PM +0200, Jakub Hrozek wrote: > > On Mon, Apr 15, 2013 at 10:34:07PM +0200, Sumit Bose wrote: > > > Hi, > > > > > > while working on adding new nss responder calls for SID related lookups > > > I realized that I

Re: [SSSD] [PATCH] Refactoring: remove duplicated code in nss responder

2013-04-19 Thread Sumit Bose
On Fri, Apr 19, 2013 at 07:47:09PM +0200, Jakub Hrozek wrote: > On Mon, Apr 15, 2013 at 10:34:07PM +0200, Sumit Bose wrote: > > Hi, > > > > while working on adding new nss responder calls for SID related lookups > > I realized that I can copy-and-paste some existing code again and add > > even mor

Re: [SSSD] [PATCH] Refactoring: remove duplicated code in nss responder

2013-04-19 Thread Jakub Hrozek
On Mon, Apr 15, 2013 at 10:34:07PM +0200, Sumit Bose wrote: > Hi, > > while working on adding new nss responder calls for SID related lookups > I realized that I can copy-and-paste some existing code again and add > even more duplication or start to refactor some of the existing code in > the nss

[SSSD] [PATCH] Refactoring: remove duplicated code in nss responder

2013-04-15 Thread Sumit Bose
Hi, while working on adding new nss responder calls for SID related lookups I realized that I can copy-and-paste some existing code again and add even more duplication or start to refactor some of the existing code in the nss responder. It preferred to second and the attached pathc is the result.