This would cause a crash if we jump to the done: label before it has been allocated.
Pushed to master under the one-liner rule. This same issue was also addressed by Jan's patch "Provide service filter for SELinux context", but only in the 1.8.x branch by mistake.
From 68559ed8f531be8fc057639cabcbb212aac13d49 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgall...@redhat.com>
Date: Fri, 15 Jun 2012 09:36:19 -0400
Subject: [PATCH] SSS_CLIENT: Fix uninitialized value error
This would cause a crash if we jump to the done: label before it
has been allocated.
---
src/sss_client/pam_sss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sss_client/pam_sss.c b/src/sss_client/pam_sss.c
index 3cffbb2e7f02e720def3dba6e77e4d08235c3b11..50c5048bf0da674a1b8cae76f23ddf180ad00da3 100644
--- a/src/sss_client/pam_sss.c
+++ b/src/sss_client/pam_sss.c
@@ -1086,7 +1086,7 @@ static int send_and_receive(pam_handle_t *pamh, struct pam_items *pi,
#ifdef HAVE_SELINUX
char *path = NULL;
char *tmp_path = NULL;
- char *services;
+ char *services = NULL;
ssize_t written;
int len;
int fd;
--
1.7.10.2
signature.asc
Description: This is a digitally signed message part
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
