Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-04-25 Thread Stephen Gallagher
On Mon, 2011-04-25 at 08:04 -0400, Stephen Gallagher wrote: > On Thu, 2011-04-21 at 14:13 +0200, Jan Zelený wrote: > > > On Thu, 2011-04-21 at 12:30 +0200, Jan Zelený wrote: > > > > > Nack. > > > > > > > > > > You still have unchecked talloc_strdup() calls in this patch in > > > > > select_princip

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-04-25 Thread Stephen Gallagher
On Thu, 2011-04-21 at 14:13 +0200, Jan Zelený wrote: > > On Thu, 2011-04-21 at 12:30 +0200, Jan Zelený wrote: > > > > Nack. > > > > > > > > You still have unchecked talloc_strdup() calls in this patch in > > > > select_principal_from_keytab(). > > > > > > I don't think so, all talloc_strdup() cal

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-04-21 Thread Jan Zelený
> On Thu, 2011-04-21 at 12:30 +0200, Jan Zelený wrote: > > > Nack. > > > > > > You still have unchecked talloc_strdup() calls in this patch in > > > select_principal_from_keytab(). > > > > I don't think so, all talloc_strdup() calls in that function are checked > > for NULL output. But there was

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-04-21 Thread Stephen Gallagher
On Thu, 2011-04-21 at 12:30 +0200, Jan Zelený wrote: > > Nack. > > > > You still have unchecked talloc_strdup() calls in this patch in > > select_principal_from_keytab(). > > I don't think so, all talloc_strdup() calls in that function are checked for > NULL output. But there was a tiny glitch,

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-04-21 Thread Jan Zelený
> Nack. > > You still have unchecked talloc_strdup() calls in this patch in > select_principal_from_keytab(). I don't think so, all talloc_strdup() calls in that function are checked for NULL output. But there was a tiny glitch, which is fixed in attached patch. Jan From 5766ed723efa52e0e1137c4

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-04-20 Thread Stephen Gallagher
On Wed, 2011-03-30 at 15:41 +0200, Jan Zelený wrote: > Stephen Gallagher wrote: > > If SDAP_SASL_AUTHID is specified, then ONLY this auth ID is allowable. > > If the keytab doesn't contain it, we need to fail. > > > > If SDAP_SASL_REALM is specified, then only the REALM portion is > > mandatory (

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-04-12 Thread Jan Zelený
Jan Zelený wrote: > Stephen Gallagher wrote: > > If SDAP_SASL_AUTHID is specified, then ONLY this auth ID is allowable. > > If the keytab doesn't contain it, we need to fail. > > > > If SDAP_SASL_REALM is specified, then only the REALM portion is > > mandatory (if we have no entries for this rea

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-03-30 Thread Jan Zelený
Stephen Gallagher wrote: > If SDAP_SASL_AUTHID is specified, then ONLY this auth ID is allowable. > If the keytab doesn't contain it, we need to fail. > > If SDAP_SASL_REALM is specified, then only the REALM portion is > mandatory (if we have no entries for this realm in the keytab, we need > to

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-03-30 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/30/2011 04:07 AM, Jan Zelený wrote: > Hi, > I'm sending corrected patches. All your suggestions and objections have been > addressed except maybe for this: > >> If the SDAP_SASL_AUTHID has been explicitly set, but the SDAP_SASL_REALM >> hasn't,

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-03-30 Thread Jan Zelený
Hi, I'm sending corrected patches. All your suggestions and objections have been addressed except maybe for this: > If the SDAP_SASL_AUTHID has been explicitly set, but the SDAP_SASL_REALM > hasn't, why are you overriding SDAP_SASL_AUTHID with > select_principal_from_keytab()? I agree with you t

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-03-29 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/29/2011 03:48 AM, Jan Zelený wrote: > Jan Zelený wrote: >> I'm sending two patches solving selection of appropriate principal for >> GSSAPI authentication from keytab file. >> >> A part of the first patch is a fix of an error present in the >> d

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-03-29 Thread Jan Zelený
Jan Zelený wrote: > I'm sending two patches solving selection of appropriate principal for > GSSAPI authentication from keytab file. > > A part of the first patch is a fix of an error present in the > documentation. I did that early in the development phase of the patch and > I didn't want to tam

Re: [SSSD] [PATCH] Select principal for GSSAPI authentication

2011-03-28 Thread Jan Zeleny
Jan Zelený wrote: > I'm sending two patches solving selection of appropriate principal for > GSSAPI authentication from keytab file. > > A part of the first patch is a fix of an error present in the > documentation. I did that early in the development phase of the patch and > I didn't want to tam

[SSSD] [PATCH] Select principal for GSSAPI authentication

2011-03-27 Thread Jan Zelený
I'm sending two patches solving selection of appropriate principal for GSSAPI authentication from keytab file. A part of the first patch is a fix of an error present in the documentation. I did that early in the development phase of the patch and I didn't want to tamper with the finished patch