Re: [SSSD] [PATCH] Suppress some compiler warnings

2010-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2010 08:58 AM, Stephen Gallagher wrote: On 09/24/2010 08:03 AM, Sumit Bose wrote: On Fri, Sep 24, 2010 at 07:20:02AM -0400, Stephen Gallagher wrote: If you're going to address the warning in write_krb5info_file(), would you mind solving

[SSSD] [PATCH] Suppress some compiler warnings

2010-09-24 Thread Sumit Bose
Hi, some of the compiler flags used to build Fedora packages, e.g. '-Wp,-D_FORTIFY_SOURCE=2' produces some extra warnings which were not addressed so far. Except the ones for krb5_common.c in 0001 they are cosmetics but might still irritate some people or tools. bye, Sumit From

Re: [SSSD] [PATCH] Suppress some compiler warnings

2010-09-24 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2010 11:32 AM, Sumit Bose wrote: Hi, some of the compiler flags used to build Fedora packages, e.g. '-Wp,-D_FORTIFY_SOURCE=2' produces some extra warnings which were not addressed so far. Except the ones for krb5_common.c in 0001 they

Re: [SSSD] [PATCH] Suppress some compiler warnings

2010-09-24 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2010 05:32 AM, Sumit Bose wrote: Hi, some of the compiler flags used to build Fedora packages, e.g. '-Wp,-D_FORTIFY_SOURCE=2' produces some extra warnings which were not addressed so far. Except the ones for krb5_common.c in 0001 they

Re: [SSSD] [PATCH] Suppress some compiler warnings

2010-09-24 Thread Sumit Bose
On Fri, Sep 24, 2010 at 07:20:02AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2010 05:32 AM, Sumit Bose wrote: Hi, some of the compiler flags used to build Fedora packages, e.g. '-Wp,-D_FORTIFY_SOURCE=2' produces some extra warnings which

Re: [SSSD] [PATCH] Suppress some compiler warnings

2010-09-24 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2010 08:03 AM, Sumit Bose wrote: On Fri, Sep 24, 2010 at 07:20:02AM -0400, Stephen Gallagher wrote: If you're going to address the warning in write_krb5info_file(), would you mind solving ALL of https://fedorahosted.org/sssd/ticket/631 in