Re: [SSSD] [PATCH] Supress warnings with -O2

2010-02-18 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/18/2010 05:46 AM, Sumit Bose wrote: > On Mon, Feb 15, 2010 at 12:26:42PM +0100, Jakub Hrozek wrote: > On 02/15/2010 11:42 AM, Sumit Bose wrote: Hi, I would solve two issues differently: > > OK, sounds good. Thanks for the suggesti

Re: [SSSD] [PATCH] Supress warnings with -O2

2010-02-18 Thread Sumit Bose
On Mon, Feb 15, 2010 at 12:26:42PM +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/15/2010 11:42 AM, Sumit Bose wrote: > > Hi, > > > > I would solve two issues differently: > > OK, sounds good. Thanks for the suggestions. > > New patch is attached. > -

Re: [SSSD] [PATCH] Supress warnings with -O2

2010-02-15 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/15/2010 11:42 AM, Sumit Bose wrote: > Hi, > > I would solve two issues differently: OK, sounds good. Thanks for the suggestions. New patch is attached. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with

Re: [SSSD] [PATCH] Supress warnings with -O2

2010-02-15 Thread Sumit Bose
On Fri, Feb 12, 2010 at 02:21:40PM +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I noticed that there were some warnings about uninitialized variables > when compiling with -O2, some of them legit (sysdb.c, krb5_auth.c, > pamsrv_cmd.c) some of them a little spuri

[SSSD] [PATCH] Supress warnings with -O2

2010-02-12 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I noticed that there were some warnings about uninitialized variables when compiling with -O2, some of them legit (sysdb.c, krb5_auth.c, pamsrv_cmd.c) some of them a little spurious but I think the extra assignments are worth the clean compile. -BE