Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-28 Thread Simo Sorce
On Fri, 25 Feb 2011 10:25:04 +0100 Sumit Bose wrote: > > Added and changed unit tests accordingly. > > Thank you. > > ACK Pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.o

Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-25 Thread Sumit Bose
On Thu, Feb 24, 2011 at 06:36:34PM +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/24/2011 01:07 PM, Sumit Bose wrote: > > Sorry for not sseing this earlier, but would you mind to move the whole > > setting of IPA_KRB5_REALM from ipa_service_init() to ipa_get

Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-24 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/24/2011 01:07 PM, Sumit Bose wrote: > Sorry for not sseing this earlier, but would you mind to move the whole > setting of IPA_KRB5_REALM from ipa_service_init() to ipa_get_options()? > I think it it safer to set it here so that it is really alwa

Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-24 Thread Sumit Bose
On Thu, Feb 24, 2011 at 12:23:05PM +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/23/2011 06:18 PM, Sumit Bose wrote: > > On Wed, Feb 23, 2011 at 05:59:13PM +0100, Jakub Hrozek wrote: > > On 02/23/2011 05:33 PM, Sumit Bose wrote: > On Wed, Feb 23, 2011

Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-24 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2011 06:18 PM, Sumit Bose wrote: > On Wed, Feb 23, 2011 at 05:59:13PM +0100, Jakub Hrozek wrote: > On 02/23/2011 05:33 PM, Sumit Bose wrote: On Wed, Feb 23, 2011 at 05:24:20PM +0100, Jakub Hrozek wrote: https://fedorahosted.org/sssd/

Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-23 Thread Sumit Bose
On Wed, Feb 23, 2011 at 05:59:13PM +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/23/2011 05:33 PM, Sumit Bose wrote: > > On Wed, Feb 23, 2011 at 05:24:20PM +0100, Jakub Hrozek wrote: > > https://fedorahosted.org/sssd/ticket/807 > > > >> NACK, please use th

Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-23 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2011 05:33 PM, Sumit Bose wrote: > On Wed, Feb 23, 2011 at 05:24:20PM +0100, Jakub Hrozek wrote: > https://fedorahosted.org/sssd/ticket/807 > >> NACK, please use the "new" option from 'Add krb5_realm to the basic IPA >> options' > >> bye, >>

Re: [SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-23 Thread Sumit Bose
On Wed, Feb 23, 2011 at 05:24:20PM +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > https://fedorahosted.org/sssd/ticket/807 NACK, please use the "new" option from 'Add krb5_realm to the basic IPA options' bye, Sumit > -BEGIN PGP SIGNATURE- > Version: Gnu

[SSSD] [PATCH] Use realm for basedn instead of IPA domain

2011-02-23 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/sssd/ticket/807 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk1lNLQACgkQHsardTLnvCXwLQCeIyfH5p8m/uHFbRvlZuoU8pam alIAoJ80vVTY6RDOd