Re: [SSSD] [PATCH] Verify LDAP file descriptor validity

2011-02-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/2011 02:31 PM, Sumit Bose wrote: > On Mon, Feb 14, 2011 at 10:15:39AM -0500, Stephen Gallagher wrote: > We weren't verifying that the file descriptor that we get back from > openldap was valid. This patch checks that the file descriptor is >=

Re: [SSSD] [PATCH] Verify LDAP file descriptor validity

2011-02-14 Thread Sumit Bose
On Mon, Feb 14, 2011 at 10:15:39AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > We weren't verifying that the file descriptor that we get back from > openldap was valid. This patch checks that the file descriptor is >= 0 > before returning it. > > There's

[SSSD] [PATCH] Verify LDAP file descriptor validity

2011-02-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We weren't verifying that the file descriptor that we get back from openldap was valid. This patch checks that the file descriptor is >= 0 before returning it. There's another (arguable) bug here in libtevent. Libtevent should probably not return succ