ehlo,
the 1st patch fixes memory leak and the second one is change in unit test
to prevent such leaks in be_ptask in feature.
LS
>From 97196e2df84ec84f9f047c20e125017ba67aa32e Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Tue, 12 Apr 2016 12:41:50 +0200
Subject: [PATCH 1/3] dp_ptask: Fix memory leak in synchronous ptask
structure be_ptask_sync_ctx was not released anywhere when
be_ptask_create_sync was used.
---
src/providers/dp_ptask.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/providers/dp_ptask.c b/src/providers/dp_ptask.c
index
3ebb134be4a991498ac5692883dd1a42416efcfe..44db3f6f8fa2582d032ae00ab1e3999e9537b025
100644
--- a/src/providers/dp_ptask.c
+++ b/src/providers/dp_ptask.c
@@ -471,6 +471,8 @@ errno_t be_ptask_create_sync(TALLOC_CTX *mem_ctx,
goto done;
}
+ talloc_steal(*_task, ctx);
+
ret = EOK;
done:
--
2.7.3
>From b53938fd4678b204fd053ae18d9d4194b7e276a3 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Tue, 12 Apr 2016 12:39:45 +0200
Subject: [PATCH 2/3] test_be_ptask: Check leaks in tests
---
src/tests/cmocka/test_be_ptask.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/tests/cmocka/test_be_ptask.c b/src/tests/cmocka/test_be_ptask.c
index
cbf61e81dd00d98cb27f87e31a0c4718f6b9a0b4..7129472ae621f6a422d0c6de59566e3b8641cfaf
100644
--- a/src/tests/cmocka/test_be_ptask.c
+++ b/src/tests/cmocka/test_be_ptask.c
@@ -286,12 +286,14 @@ static int test_setup(void **state)
test_ctx->be_ctx->ev = tevent_context_init(test_ctx->be_ctx);
assert_non_null(test_ctx->be_ctx->ev);
+ check_leaks_push(test_ctx);
*state = test_ctx;
return 0;
}
static int test_teardown(void **state)
{
+ assert_true(check_leaks_pop(*state));
talloc_zfree(*state);
assert_true(leak_check_teardown());
return 0;
--
2.7.3
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
