Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-10-07 Thread Nikolai Kondrashov
On 10/07/2015 10:51 AM, Lukas Slebodnik wrote: On (06/10/15 11:27), Jakub Hrozek wrote: On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: Remove "_rfc2307" from integration test function names for brevity. Please do not remove sanity_rfc2307 from this test. It was added inte

Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-10-07 Thread Nikolai Kondrashov
On 10/07/2015 04:13 PM, Jakub Hrozek wrote: On Wed, Oct 07, 2015 at 04:02:32PM +0300, Nikolai Kondrashov wrote: On 10/06/2015 12:27 PM, Jakub Hrozek wrote: On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: Hi everyone, Here is a patch set fixing some things in integration te

Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-10-07 Thread Jakub Hrozek
On Wed, Oct 07, 2015 at 04:02:32PM +0300, Nikolai Kondrashov wrote: > On 10/06/2015 12:27 PM, Jakub Hrozek wrote: > >On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: > >>Hi everyone, > >> > >>Here is a patch set fixing some things in integration tests and adding more > >>LDAP tes

Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-10-07 Thread Nikolai Kondrashov
On 10/06/2015 12:27 PM, Jakub Hrozek wrote: On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: Hi everyone, Here is a patch set fixing some things in integration tests and adding more LDAP tests: (Not a full review, just adding my ideas and impressions) I read these patches

Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-10-07 Thread Lukas Slebodnik
On (06/10/15 11:27), Jakub Hrozek wrote: >On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: >> Hi everyone, >> >> Here is a patch set fixing some things in integration tests and adding more >> LDAP tests: > >(Not a full review, just adding my ideas and impressions) > >I read thes

Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-10-06 Thread Jakub Hrozek
On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: > Hi everyone, > > Here is a patch set fixing some things in integration tests and adding more > LDAP tests: (Not a full review, just adding my ideas and impressions) I read these patches when I tried to add tests for the failin

Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-09-30 Thread Nikolai Kondrashov
On 09/30/2015 06:15 PM, Nikolai Kondrashov wrote: NOTE: These still break test_memory_cache.py as seen in the attached log file. Here's a fresher log, with the correct line numbers: http://sssd-ci.duckdns.org/logs/job/28/19/rhel7/ci-build-debug/ci-make-intgcheck.log Nick _

Re: [SSSD] [PATCH] intg: Add more LDAP tests

2015-09-30 Thread Nikolai Kondrashov
On 09/30/2015 06:15 PM, Nikolai Kondrashov wrote: -create_conf_fixture(request, conf) +create_conf_fixture(request, format_basic_conf(ldap_conn, False, True)) Actually, I wanted to do one more thing with this and forgot: name the "bis" and "enum" parameters explicitly on each invocation

[SSSD] [PATCH] intg: Add more LDAP tests

2015-09-30 Thread Nikolai Kondrashov
Hi everyone, Here is a patch set fixing some things in integration tests and adding more LDAP tests: * Adding/removing a user/group/membership with rfc2307(bis) schema. * Filtering users/groups with rfc2307(bis) schema. * The effect of override_homedir option. * The effect of fal