Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 03:54 PM, Stephen Gallagher wrote: > > > I just tested building this. I see no warnings in this code. > > Ack. > Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in v

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 03:49 PM, Simo Sorce wrote: > This is because you applied this patch before the enumgrent optimization > one. That patch removes the uid and comes before this patch in my tree. > > Simo. > I just tested building this. I see no warnings

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 21:35 +0100, Sumit Bose wrote: > On Fri, Nov 20, 2009 at 01:36:30PM -0500, Simo Sorce wrote: > > On Fri, 2009-11-20 at 10:40 +0100, Sumit Bose wrote: > > > Works well, especially with Optimize-sysdb_enumgrent.patch, but > > > please create a utility function or a macro for the

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Sumit Bose
On Fri, Nov 20, 2009 at 01:36:30PM -0500, Simo Sorce wrote: > On Fri, 2009-11-20 at 10:40 +0100, Sumit Bose wrote: > > Works well, especially with Optimize-sysdb_enumgrent.patch, but > > please create a utility function or a macro for the range check and > > fix > > Revised patch to use a macro. >

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 10:40 +0100, Sumit Bose wrote: > Works well, especially with Optimize-sysdb_enumgrent.patch, but > please create a utility function or a macro for the range check and > fix Revised patch to use a macro. -- Simo Sorce * Red Hat, Inc * New York >From 723f6d0750ea952b1b4ec3c92

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 11:19 +0100, Sumit Bose wrote: > On Fri, Nov 20, 2009 at 10:40:29AM +0100, Sumit Bose wrote: > > On Wed, Nov 18, 2009 at 12:09:58PM -0500, Simo Sorce wrote: > > > This way we check them once at storage time instead of checking again > > > and again at search time. > > > > > >

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Sumit Bose
On Fri, Nov 20, 2009 at 10:40:29AM +0100, Sumit Bose wrote: > On Wed, Nov 18, 2009 at 12:09:58PM -0500, Simo Sorce wrote: > > This way we check them once at storage time instead of checking again > > and again at search time. > > > > Applies only on top of the sysdb_enumgrent optimization patch. >

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Sumit Bose
On Wed, Nov 18, 2009 at 12:09:58PM -0500, Simo Sorce wrote: > This way we check them once at storage time instead of checking again > and again at search time. > > Applies only on top of the sysdb_enumgrent optimization patch. > > Simo. > Works well, especially with Optimize-sysdb_enumgrent.pat

[SSSD] [PATCH] move id range checks into providers

2009-11-18 Thread Simo Sorce
This way we check them once at storage time instead of checking again and again at search time. Applies only on top of the sysdb_enumgrent optimization patch. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 3bc78051e26983e5741c02d7fce82d4b683cc722 Mon Sep 17 00:00:00 2001 From: Simo Sorce