Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-06-03 Thread Jakub Hrozek
On Tue, Jun 03, 2014 at 11:15:41AM +0200, Jakub Hrozek wrote: > On Tue, Jun 03, 2014 at 11:04:19AM +0200, Sumit Bose wrote: > > > > Arguments ignore_unknown_user ignore_authinfo_unavail are also > > > > implemented in pam_ldap. > > > > > > > > > > > > > Not a full review, just a grammar review o

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-06-03 Thread Jakub Hrozek
On Tue, Jun 03, 2014 at 11:04:19AM +0200, Sumit Bose wrote: > > > Arguments ignore_unknown_user ignore_authinfo_unavail are also > > > implemented in pam_ldap. > > > > > > > > > Not a full review, just a grammar review of the manpage. > > > > Ack to the manpage phrasing. > > I tested the patch

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-06-03 Thread Sumit Bose
On Fri, May 30, 2014 at 09:36:08AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Mon 26 May 2014 06:18:08 PM EDT, Lukas Slebodnik wrote: > > On (14/03/14 14:22), Jakub Hrozek wrote: > >> On Fri, Mar 14, 2014 at 02:14:04PM +0100, Lukas Slebodnik wrote: > >

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-05-30 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon 26 May 2014 06:18:08 PM EDT, Lukas Slebodnik wrote: > On (14/03/14 14:22), Jakub Hrozek wrote: >> On Fri, Mar 14, 2014 at 02:14:04PM +0100, Lukas Slebodnik wrote: >>> On (13/03/14 15:24), Pete Fritchman wrote: On Thu, Mar 13, 2014 at 1:28 P

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-05-26 Thread Lukas Slebodnik
On (14/03/14 14:22), Jakub Hrozek wrote: >On Fri, Mar 14, 2014 at 02:14:04PM +0100, Lukas Slebodnik wrote: >> On (13/03/14 15:24), Pete Fritchman wrote: >> >On Thu, Mar 13, 2014 at 1:28 PM, Jakub Hrozek wrote: >> >> would you like any help amending the patch ? Are you still planning on >> >> re-se

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-03-14 Thread Jakub Hrozek
On Fri, Mar 14, 2014 at 02:14:04PM +0100, Lukas Slebodnik wrote: > On (13/03/14 15:24), Pete Fritchman wrote: > >On Thu, Mar 13, 2014 at 1:28 PM, Jakub Hrozek wrote: > >> would you like any help amending the patch ? Are you still planning on > >> re-sending it? > > > >Hi Jakub, > > > >Sorry - I fo

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-03-14 Thread Jakub Hrozek
On Fri, Mar 14, 2014 at 02:05:00PM +0100, Jakub Hrozek wrote: > On Thu, Mar 13, 2014 at 03:24:13PM -0400, Pete Fritchman wrote: > > On Thu, Mar 13, 2014 at 1:28 PM, Jakub Hrozek wrote: > > > would you like any help amending the patch ? Are you still planning on > > > re-sending it? > > > > Hi Jak

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-03-14 Thread Lukas Slebodnik
On (13/03/14 15:24), Pete Fritchman wrote: >On Thu, Mar 13, 2014 at 1:28 PM, Jakub Hrozek wrote: >> would you like any help amending the patch ? Are you still planning on >> re-sending it? > >Hi Jakub, > >Sorry - I forgot to follow up to this thread. I attached a new patch >to the ticket that inc

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-03-14 Thread Jakub Hrozek
On Thu, Mar 13, 2014 at 03:24:13PM -0400, Pete Fritchman wrote: > On Thu, Mar 13, 2014 at 1:28 PM, Jakub Hrozek wrote: > > would you like any help amending the patch ? Are you still planning on > > re-sending it? > > Hi Jakub, > > Sorry - I forgot to follow up to this thread. I attached a new p

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-03-13 Thread Pete Fritchman
On Thu, Mar 13, 2014 at 1:28 PM, Jakub Hrozek wrote: > would you like any help amending the patch ? Are you still planning on > re-sending it? Hi Jakub, Sorry - I forgot to follow up to this thread. I attached a new patch to the ticket that includes the case where send_and_receive returns PAM_I

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-03-13 Thread Jakub Hrozek
On Wed, Feb 12, 2014 at 11:39:28AM +0100, Jakub Hrozek wrote: > On Tue, Feb 11, 2014 at 11:00:08AM -0500, Pete Fritchman wrote: > > https://fedorahosted.org/sssd/ticket/2232 > > > > FreeBSD's openpam doesn't have a built in way of ignoring an unknown > > user (e.g. treating PAM_USER_UNKNOWN as a p

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-02-12 Thread Jakub Hrozek
On Wed, Feb 12, 2014 at 12:36:14PM +0200, Alexander Bokovoy wrote: > On Tue, 11 Feb 2014, Pete Fritchman wrote: > >https://fedorahosted.org/sssd/ticket/2232 > > > >FreeBSD's openpam doesn't have a built in way of ignoring an unknown > >user (e.g. treating PAM_USER_UNKNOWN as a pass for a required m

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-02-12 Thread Jakub Hrozek
On Tue, Feb 11, 2014 at 11:00:08AM -0500, Pete Fritchman wrote: > https://fedorahosted.org/sssd/ticket/2232 > > FreeBSD's openpam doesn't have a built in way of ignoring an unknown > user (e.g. treating PAM_USER_UNKNOWN as a pass for a required module, > like Linux's user_unknown=ignore tag), so t

Re: [SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-02-12 Thread Alexander Bokovoy
On Tue, 11 Feb 2014, Pete Fritchman wrote: https://fedorahosted.org/sssd/ticket/2232 FreeBSD's openpam doesn't have a built in way of ignoring an unknown user (e.g. treating PAM_USER_UNKNOWN as a pass for a required module, like Linux's user_unknown=ignore tag), so there needs to be an ignore_un

[SSSD] [PATCH] pam_sss: add ignore_unknown_user option

2014-02-11 Thread Pete Fritchman
https://fedorahosted.org/sssd/ticket/2232 FreeBSD's openpam doesn't have a built in way of ignoring an unknown user (e.g. treating PAM_USER_UNKNOWN as a pass for a required module, like Linux's user_unknown=ignore tag), so there needs to be an ignore_unknown_user flag built in to the PAM module. T