Re: [SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-19 Thread Jakub Hrozek
On Sun, Nov 18, 2012 at 10:29:46PM +0100, Jakub Hrozek wrote: On Sun, Nov 18, 2012 at 03:54:54PM -0500, Simo Sorce wrote: On Sun, 2012-11-18 at 18:27 +0100, Jakub Hrozek wrote: On Sun, Nov 18, 2012 at 06:05:45PM +0100, Sumit Bose wrote: On Fri, Nov 16, 2012 at 04:25:41PM -0500, Simo

Re: [SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-18 Thread Sumit Bose
On Fri, Nov 16, 2012 at 04:25:41PM -0500, Simo Sorce wrote: Sumit found 2 issues in the patch. 1. the 2 new wrapper proptotypes used _res as variable names but that symbol is now used in glibc: /usr/include/resolv.h:#define _res (*__res_state()) Changed to 'res' 2. I was still using

Re: [SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-18 Thread Jakub Hrozek
On Sun, Nov 18, 2012 at 06:05:45PM +0100, Sumit Bose wrote: On Fri, Nov 16, 2012 at 04:25:41PM -0500, Simo Sorce wrote: Sumit found 2 issues in the patch. 1. the 2 new wrapper proptotypes used _res as variable names but that symbol is now used in glibc: /usr/include/resolv.h:#define

Re: [SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-18 Thread Simo Sorce
On Sun, 2012-11-18 at 18:27 +0100, Jakub Hrozek wrote: On Sun, Nov 18, 2012 at 06:05:45PM +0100, Sumit Bose wrote: On Fri, Nov 16, 2012 at 04:25:41PM -0500, Simo Sorce wrote: Sumit found 2 issues in the patch. 1. the 2 new wrapper proptotypes used _res as variable names but that

Re: [SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-18 Thread Jakub Hrozek
On Sun, Nov 18, 2012 at 03:54:54PM -0500, Simo Sorce wrote: On Sun, 2012-11-18 at 18:27 +0100, Jakub Hrozek wrote: On Sun, Nov 18, 2012 at 06:05:45PM +0100, Sumit Bose wrote: On Fri, Nov 16, 2012 at 04:25:41PM -0500, Simo Sorce wrote: Sumit found 2 issues in the patch. 1. the 2

[SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-16 Thread Simo Sorce
Added wrappers as Sumit requested. Simo Sorce (2): Refactor the way subdomain accounts are saved Handle conversion to fully qualified usernames Sumit Bose (1): Do not save HBAC rules in subdomain subtree src/db/sysdb.c |7 +++ src/db/sysdb.h

Re: [SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-16 Thread Simo Sorce
On Fri, 2012-11-16 at 13:34 -0500, Simo Sorce wrote: Added wrappers as Sumit requested. Please ignore this set, I introduced a crash bug in refactoring the getXXnam() calls as Sumit asked. I'll send a new patchset soon. Simo. -- Simo Sorce * Red Hat, Inc * New York

[SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-16 Thread Simo Sorce
Resolved segfault, everything else as before. Simo Sorce (2): Refactor the way subdomain accounts are saved Handle conversion to fully qualified usernames Sumit Bose (1): Do not save HBAC rules in subdomain subtree src/db/sysdb.c |7 +++ src/db/sysdb.h

[SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-16 Thread Simo Sorce
Sumit found 2 issues in the patch. 1. the 2 new wrapper proptotypes used _res as variable names but that symbol is now used in glibc: /usr/include/resolv.h:#define _res (*__res_state()) Changed to 'res' 2. I was still using const char *src_name but it is unnecessary Dropped the const This