Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-29 Thread Michal Židek
On 04/25/2013 05:18 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/24/2013 06:11 PM, Simo Sorce wrote: On Wed, 2013-04-24 at 20:55 +0200, Sumit Bose wrote: On Wed, Apr 24, 2013 at 02:22:42PM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE-

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-29 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/29/2013 06:46 AM, Michal Židek wrote: On 04/25/2013 05:18 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/24/2013 06:11 PM, Simo Sorce wrote: On Wed, 2013-04-24 at 20:55 +0200, Sumit Bose wrote: On Wed,

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-29 Thread Jakub Hrozek
On Mon, Apr 29, 2013 at 08:13:21AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/29/2013 06:46 AM, Michal Židek wrote: On 04/25/2013 05:18 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/24/2013 06:11 PM, Simo

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-24 Thread Sumit Bose
On Tue, Apr 23, 2013 at 01:50:35PM -0400, Simo Sorce wrote: On Tue, 2013-04-23 at 11:26 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/23/2013 10:37 AM, Michal Židek wrote: Also one more question. How should I amend the -version-info value for

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-24 Thread Michal Židek
On 04/24/2013 10:08 AM, Sumit Bose wrote: On Tue, Apr 23, 2013 at 01:50:35PM -0400, Simo Sorce wrote: On Tue, 2013-04-23 at 11:26 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/23/2013 10:37 AM, Michal Židek wrote: Also one more question. How should I

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-24 Thread Sumit Bose
On Wed, Apr 24, 2013 at 01:34:07PM +0200, Michal Židek wrote: On 04/24/2013 10:08 AM, Sumit Bose wrote: On Tue, Apr 23, 2013 at 01:50:35PM -0400, Simo Sorce wrote: On Tue, 2013-04-23 at 11:26 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/23/2013 10:37

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-24 Thread Michal Židek
On 04/24/2013 02:15 PM, Sumit Bose wrote: On Wed, Apr 24, 2013 at 01:34:07PM +0200, Michal Židek wrote: On 04/24/2013 10:08 AM, Sumit Bose wrote: On Tue, Apr 23, 2013 at 01:50:35PM -0400, Simo Sorce wrote: On Tue, 2013-04-23 at 11:26 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-24 Thread Michal Židek
New version of the patch is attached. Changes from previous iteration: - version-info set to 0:2:0 - init function remains backward compatible, but it sets default oadptions needed for range calculation. Non default values can be set via ded setters. - sss_idmap_opts moved to private header -

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-24 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed 24 Apr 2013 02:05:55 PM EDT, Michal Židek wrote: New version of the patch is attached. Changes from previous iteration: - version-info set to 0:2:0 - init function remains backward compatible, but it sets default oadptions needed for

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-24 Thread Sumit Bose
On Wed, Apr 24, 2013 at 02:22:42PM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed 24 Apr 2013 02:05:55 PM EDT, Michal Židek wrote: New version of the patch is attached. Changes from previous iteration: - version-info set to 0:2:0 - init function

[SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-23 Thread Michal Židek
The first patch solves ticket https://fedorahosted.org/sssd/ticket/1844 The second modifies the test suite to reflect these changes. The patch moves calculation of UID range for a domain from sdap_idmap code to sss_idmap. Some changes are: - Structure sdap_idmap_slice has been removed. The

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-23 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/23/2013 10:37 AM, Michal Židek wrote: The first patch solves ticket https://fedorahosted.org/sssd/ticket/1844 The second modifies the test suite to reflect these changes. The patch moves calculation of UID range for a domain from

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-23 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/23/2013 10:37 AM, Michal Židek wrote: Also one more question. How should I amend the -version-info value for libsss_idmap in Makefile.am? Currently it is 0:1:0. Should it be 1:0:0 now? With your patch as written, yes you will need to

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-23 Thread Dmitri Pal
On 04/23/2013 10:59 AM, Stephen Gallagher wrote: On 04/23/2013 10:37 AM, Michal Židek wrote: The first patch solves ticket https://fedorahosted.org/sssd/ticket/1844 The second modifies the test suite to reflect these changes. The patch moves calculation of UID range for a domain from

Re: [SSSD] [PATCH 1/2] libsss_idmap: function to calculate range

2013-04-23 Thread Simo Sorce
On Tue, 2013-04-23 at 11:26 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/23/2013 10:37 AM, Michal Židek wrote: Also one more question. How should I amend the -version-info value for libsss_idmap in Makefile.am? Currently it is 0:1:0. Should it be