Re: [SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-26 Thread Jakub Hrozek
On Wed, Mar 25, 2015 at 05:11:26PM +0100, Pavel Reichl wrote: > >>>diff --git a/src/tests/cmocka/test_expire_common.c > >>>b/src/tests/cmocka/test_expire_common.c > >>>index > >>>1698bd80e7c3bb992717906506533bb15e17944e..5d3ea02f3e5f0316cdf812368c361edc52459781 > >>> 100644 > >>>--- a/src/tests/c

Re: [SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Pavel Reichl
On 03/25/2015 05:09 PM, Lukas Slebodnik wrote: On (25/03/15 16:29), Pavel Reichl wrote: On 03/25/2015 03:21 PM, Lukas Slebodnik wrote: ehlo, Documentation to macro assert_return_code says: Assert that the return_code is greater than or equal to 0. The function prints an error message to sta

Re: [SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 16:29), Pavel Reichl wrote: >On 03/25/2015 03:21 PM, Lukas Slebodnik wrote: >>ehlo, >> >>Documentation to macro assert_return_code says: >>Assert that the return_code is greater than or equal to 0. >> >>The function prints an error message to standard error and terminates the >>test by

Re: [SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Pavel Reichl
On 03/25/2015 03:21 PM, Lukas Slebodnik wrote: ehlo, Documentation to macro assert_return_code says: Assert that the return_code is greater than or equal to 0. The function prints an error message to standard error and terminates the test by calling fail() if the return code is smaller than 0.

[SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Lukas Slebodnik
ehlo, Documentation to macro assert_return_code says: Assert that the return_code is greater than or equal to 0. The function prints an error message to standard error and terminates the test by calling fail() if the return code is smaller than 0. If the function you check sets an errno if it fai