Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-12-18 Thread Nikolai Kondrashov
Hi Stephen, On 12/18/2013 07:55 PM, Stephen Gallagher wrote: Nikolai, has there been any progress on this? I'd actually really like to see these changes land, as they'll make my life easier as I work on journald support for the debug logs. What I'm looking for is mostly the variadic change (so

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-12-18 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu 17 Oct 2013 05:23:36 AM EDT, Nikolai Kondrashov wrote: > On 10/17/2013 12:16 PM, Nikolai Kondrashov wrote: >> On 10/15/2013 07:19 PM, Jakub Hrozek wrote: >>> On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote: Finally if everybody a

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-17 Thread Nikolai Kondrashov
On 10/17/2013 12:16 PM, Nikolai Kondrashov wrote: On 10/15/2013 07:19 PM, Jakub Hrozek wrote: On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote: Finally if everybody agree they want to make this huge change, *then* I absolutely want to see each change also change debug numbers from num

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-17 Thread Nikolai Kondrashov
On 10/15/2013 07:19 PM, Jakub Hrozek wrote: On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote: Finally if everybody agree they want to make this huge change, *then* I absolutely want to see each change also change debug numbers from numbers to the new macros. It makes no sense whatsoeve

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-16 Thread Nikolai Kondrashov
On 10/15/2013 07:24 PM, Jakub Hrozek wrote: On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote: Finally if everybody agree they want to make this huge change, *then* I absolutely want to see each change also change debug numbers from numbers to the new macros. It makes no sense whatsoeve

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-15 Thread Jakub Hrozek
On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote: > Finally if everybody agree they want to make this huge change, *then* I > absolutely want to see each change also change debug numbers from > numbers to the new macros. It makes no sense whatsoever to change the > DEBUG form and leave in

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-15 Thread Jakub Hrozek
On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote: > On Fri, 2013-10-11 at 15:21 +0200, Sumit Bose wrote: > > On Fri, Oct 11, 2013 at 08:53:11AM -0400, Simo Sorce wrote: > > > On Fri, 2013-10-11 at 11:09 +0300, Nikolai Kondrashov wrote: > > > > On 10/10/2013 11:27 PM, Simo Sorce wrote: > >

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Michal Židek
On 10/11/2013 10:09 AM, Nikolai Kondrashov wrote: On 10/10/2013 11:27 PM, Simo Sorce wrote: On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote: Make DEBUG macro accept variable number of ar

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Simo Sorce
On Fri, 2013-10-11 at 15:21 +0200, Sumit Bose wrote: > On Fri, Oct 11, 2013 at 08:53:11AM -0400, Simo Sorce wrote: > > On Fri, 2013-10-11 at 11:09 +0300, Nikolai Kondrashov wrote: > > > On 10/10/2013 11:27 PM, Simo Sorce wrote: > > > > On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote: > >

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Sumit Bose
On Fri, Oct 11, 2013 at 08:53:11AM -0400, Simo Sorce wrote: > On Fri, 2013-10-11 at 11:09 +0300, Nikolai Kondrashov wrote: > > On 10/10/2013 11:27 PM, Simo Sorce wrote: > > > On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote: > > >> -BEGIN PGP SIGNED MESSAGE- > > >> Hash: SHA1 > >

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Simo Sorce
On Fri, 2013-10-11 at 11:09 +0300, Nikolai Kondrashov wrote: > On 10/10/2013 11:27 PM, Simo Sorce wrote: > > On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote: > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote: > >>> Make DEB

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Nikolai Kondrashov
On 10/11/2013 11:25 AM, Nikolai Kondrashov wrote: On 10/11/2013 11:23 AM, Nikolai Kondrashov wrote: On 10/11/2013 11:17 AM, Jakub Hrozek wrote: Can you also send the next round of patches gzipped so that you don't have to wait until they make it through moderation? Sure, I will. Although, IM

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Nikolai Kondrashov
On 10/11/2013 11:23 AM, Nikolai Kondrashov wrote: On 10/11/2013 11:17 AM, Jakub Hrozek wrote: Can you also send the next round of patches gzipped so that you don't have to wait until they make it through moderation? Sure, I will. Although, IMHO, it makes it harder to respond to particular pat

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Nikolai Kondrashov
On 10/11/2013 11:17 AM, Jakub Hrozek wrote: Can you also send the next round of patches gzipped so that you don't have to wait until they make it through moderation? Sure, I will. Although, IMHO, it makes it harder to respond to particular patches and snippets and discuss effectively. Sincere

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Jakub Hrozek
On Fri, Oct 11, 2013 at 11:09:35AM +0300, Nikolai Kondrashov wrote: > On 10/10/2013 11:27 PM, Simo Sorce wrote: > >On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote: > >>-BEGIN PGP SIGNED MESSAGE- > >>Hash: SHA1 > >> > >>On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote: > >>>Make D

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Nikolai Kondrashov
On 10/10/2013 11:27 PM, Simo Sorce wrote: On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote: Make DEBUG macro accept variable number of arguments, thus removing the need to wrap the format

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-11 Thread Nikolai Kondrashov
Hi Stephen, On 10/10/2013 10:46 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote: Make DEBUG macro accept variable number of arguments, thus removing the need to wrap the format string and its arguments into parens on i

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-10 Thread Simo Sorce
On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote: > > Make DEBUG macro accept variable number of arguments, thus removing > > the need to wrap the format string and its arguments into

Re: [SSSD] [PATCH 3/4] Make DEBUG macro variadic

2013-10-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote: > Make DEBUG macro accept variable number of arguments, thus removing > the need to wrap the format string and its arguments into parens > on invocation. Nack. Please do us a favor and split this into