Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-02-05 Thread Jakub Hrozek
On Mon, Feb 03, 2014 at 11:34:21AM +0100, Lukas Slebodnik wrote: > I tested patch and works fine. > Thank you for you effort to remove cast-align warnings. > There are few warnings in sssd build but they are unrelated to this patch. > > ACK Pushed to master. __

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-02-05 Thread Jakub Hrozek
On Mon, Feb 03, 2014 at 11:34:21AM +0100, Lukas Slebodnik wrote: > >New patch attached. > > > >Michal > > >From 752013562af83c338344613b7278f7cc2cae6a36 Mon Sep 17 00:00:00 2001 > >From: Michal Zidek > >Date: Wed, 28 Aug 2013 12:46:58 +0200 > >Subject: [PATCH] responder: Use SAFEALIGN macros wher

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-02-03 Thread Lukas Slebodnik
On (31/01/14 19:51), Michal Židek wrote: >On 01/31/2014 07:45 PM, Lukas Slebodnik wrote: >>Almost good, except few warnings (in my case errors) >>src/responder/nss/nsssrv_cmd.c:3578:52: error: incompatible pointer types >>passing 'int *' to >> parameter of type 'size_t *' (aka 'unsigned long

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-01-31 Thread Michal Židek
On 01/31/2014 07:45 PM, Lukas Slebodnik wrote: Almost good, except few warnings (in my case errors) src/responder/nss/nsssrv_cmd.c:3578:52: error: incompatible pointer types passing 'int *' to parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-01-31 Thread Lukas Slebodnik
On (31/01/14 19:02), Michal Židek wrote: >On 01/31/2014 06:12 PM, Lukas Slebodnik wrote: >>On (29/01/14 15:39), Michal Židek wrote: >>>On 01/22/2014 07:50 PM, Lukas Slebodnik wrote: This patch needs to be rebased. LS ___ sssd-devel ma

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-01-31 Thread Michal Židek
On 01/31/2014 06:12 PM, Lukas Slebodnik wrote: On (29/01/14 15:39), Michal Židek wrote: On 01/22/2014 07:50 PM, Lukas Slebodnik wrote: This patch needs to be rebased. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedo

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-01-31 Thread Lukas Slebodnik
On (29/01/14 15:39), Michal Židek wrote: >On 01/22/2014 07:50 PM, Lukas Slebodnik wrote: >>This patch needs to be rebased. >> >>LS >>___ >>sssd-devel mailing list >>sssd-devel@lists.fedorahosted.org >>https://lists.fedorahosted.org/mailman/listinfo/sssd-d

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-01-29 Thread Michal Židek
On 01/22/2014 07:50 PM, Lukas Slebodnik wrote: This patch needs to be rebased. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel Rebased patch attached. Michal >From e00ca056

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2014-01-22 Thread Lukas Slebodnik
On (19/11/13 14:01), Michal Židek wrote: >On 11/18/2013 04:02 PM, Lukas Slebodnik wrote: >>Few warnings are not fixed in the file src/responder/nss/nsssrv_cmd.c >>and patches {0005, 0006} do not change this file. >> >> CC src/responder/nss/nsssrv_cmd.o >>src/responder/nss/nsssrv_cmd.c:1017:

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2013-11-28 Thread Michal Židek
On 11/28/2013 11:59 AM, Lukas Slebodnik wrote: On (19/11/13 14:01), Michal Židek wrote: On 11/18/2013 04:02 PM, Lukas Slebodnik wrote: Few warnings are not fixed in the file src/responder/nss/nsssrv_cmd.c and patches {0005, 0006} do not change this file. CC src/responder/nss/nsssrv_cm

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2013-11-28 Thread Lukas Slebodnik
On (19/11/13 14:01), Michal Židek wrote: >On 11/18/2013 04:02 PM, Lukas Slebodnik wrote: >>Few warnings are not fixed in the file src/responder/nss/nsssrv_cmd.c >>and patches {0005, 0006} do not change this file. >> >> CC src/responder/nss/nsssrv_cmd.o >>src/responder/nss/nsssrv_cmd.c:1017:

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2013-11-19 Thread Michal Židek
On 11/18/2013 04:02 PM, Lukas Slebodnik wrote: Few warnings are not fixed in the file src/responder/nss/nsssrv_cmd.c and patches {0005, 0006} do not change this file. CC src/responder/nss/nsssrv_cmd.o src/responder/nss/nsssrv_cmd.c:1017:6: warning: cast from 'uint8_t *' (aka 'unsigned

Re: [SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2013-11-18 Thread Lukas Slebodnik
On (15/11/13 17:28), Michal Židek wrote: >On 11/14/2013 01:14 PM, Lukas Slebodnik wrote:>>From >>> >-((uint32_t *)body)[0] = num-skipped; /* num results */ >>> >-((uint32_t *)body)[1] = 0; /* reserved */ >>> >+SAFEALIGN_SETMEM_UINT32(body, num - skipped, NULL); /* num >results */ >>> >+

[SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

2013-11-15 Thread Michal Židek
On 11/14/2013 01:14 PM, Lukas Slebodnik wrote:>>From >> >-((uint32_t *)body)[0] = num-skipped; /* num results */ >> >-((uint32_t *)body)[1] = 0; /* reserved */ >> >+SAFEALIGN_SETMEM_UINT32(body, num - skipped, NULL); /* num results */ >> >+SAFEALIGN_SETMEM_UINT32(body + sizeof(uin