Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-29 Thread Stephen Gallagher
On Fri, 2012-06-29 at 16:01 +0200, Jan Zelený wrote: > Ack to all patches except for the man page which I'd like to leave for native > English speaker to check it. > > Also, please note that I didn't have time to test everything working together > so some testing should be performed before push

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-29 Thread Jan Zelený
Dne pátek 29 června 2012 15:33:14, Pavel Březina napsal(a): > On 29.6.2012 14:31, Jan Zelený wrote: > > Patches #0001 - #0031: > > > > Ack, without further comments > > > >>> Patch #0032: Nack, > >>> please change the big comment as follows: > >>> > >>> +/* fetch only expired rules > >>> +

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-29 Thread Jan Zelený
Patches #0001 - #0031: Ack, without further comments > > Patch #0032: Nack, > > please change the big comment as follows: > > > > +/* fetch only expired rules > > + * this is because sudo ask sssd two times - for defaults and for > > rules + * when we refresh all expired rules (of t

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-28 Thread Jan Zelený
Dne čtvrtek 28 června 2012 12:42:37, Pavel Březina napsal(a): > On 06/27/2012 04:28 PM, Jan Zelený wrote: > >>> Ack to patches #0001-#0018. I haven't tested them yet though. > >>> > >>> Thanks > >>> Jan > >> > >> I have found an issue in the timer API. I did not clear timeout after > >> the request

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-27 Thread Jan Zelený
> > Ack to patches #0001-#0018. I haven't tested them yet though. > > > > Thanks > > Jan > > I have found an issue in the timer API. I did not clear timeout after > the request has been completed which cause SIGABRT in talloc function. > Patches are attached. Ack to the fix, another part of revi

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-27 Thread Jan Zelený
Dne středa 27 června 2012 13:31:42, Pavel Březina napsal(a): > On 06/27/2012 11:05 AM, Jan Zelený wrote: > > Dne úterý 26 června 2012 18:22:15, Pavel Březina napsal(a): > >> On 06/26/2012 03:45 PM, Jan Zelený wrote: > >>> Dne úterý 26 června 2012 10:08:15, Pavel Březina napsal(a): > On 06/21/2

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-27 Thread Jan Zelený
Dne úterý 26 června 2012 18:22:15, Pavel Březina napsal(a): > On 06/26/2012 03:45 PM, Jan Zelený wrote: > > Dne úterý 26 června 2012 10:08:15, Pavel Březina napsal(a): > >> On 06/21/2012 05:32 PM, Pavel Březina wrote: > >>> On 3.6.2012 22:17, Pavel Březina wrote: > On 14.5.2012 22:37, Jakub Hr

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-06-26 Thread Jan Zelený
Dne úterý 26 června 2012 10:08:15, Pavel Březina napsal(a): > On 06/21/2012 05:32 PM, Pavel Březina wrote: > > On 3.6.2012 22:17, Pavel Březina wrote: > >> On 14.5.2012 22:37, Jakub Hrozek wrote: > >>> On Mon, May 14, 2012 at 06:39:30PM +0200, Pavel Březina wrote: > On 9.5.2012 17:07, Pavel Bř

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Jakub Hrozek
On Mon, May 14, 2012 at 06:39:30PM +0200, Pavel Březina wrote: > On 9.5.2012 17:07, Pavel Březina wrote: > >On 05/07/2012 07:13 PM, Pavel Březina wrote: > >>On 04/23/2012 06:34 PM, Pavel Březina wrote: > >>>On 04/23/2012 05:04 PM, Pavel Březina wrote: > Hello everybody, > here is the first

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Pavel Březina
On 14.5.2012 20:40, Stephen Gallagher wrote: On Mon, 2012-05-14 at 13:16 -0400, Simo Sorce wrote: On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote: - it ignores modifyTimestamp - simo suggested to use it in smart refresh when enabled in configuration and USN not available, but do

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 13:16 -0400, Simo Sorce wrote: > On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote: > > - it ignores modifyTimestamp - simo suggested to use it in smart > > refresh when enabled in configuration and USN not available, but > > do > > we really want to use it? There

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Simo Sorce
On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote: > - it ignores modifyTimestamp - simo suggested to use it in smart > refresh when enabled in configuration and USN not available, but > do > we really want to use it? There is no other part in sssd that uses > it > (or am I wrong?)