Re: [SSSD] [PATCHES] Fix several warnings/potential bugs

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/08/2009 11:41 AM, Simo Sorce wrote: > On Tue, 2009-12-08 at 11:27 -0500, Stephen Gallagher wrote: >> Patch 0001: We weren't checking that the asprintf was successfully >> allocating memory. I converted it to talloc_asprintf() for uniformity >> as

Re: [SSSD] [PATCHES] Fix several warnings/potential bugs

2009-12-08 Thread Simo Sorce
On Tue, 2009-12-08 at 11:27 -0500, Stephen Gallagher wrote: > Patch 0001: We weren't checking that the asprintf was successfully > allocating memory. I converted it to talloc_asprintf() for uniformity > as > well. > > Patch 0002: If grouplist was a zero-length array, we would return ret > unitiali

[SSSD] [PATCHES] Fix several warnings/potential bugs

2009-12-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patch 0001: We weren't checking that the asprintf was successfully allocating memory. I converted it to talloc_asprintf() for uniformity as well. Patch 0002: If grouplist was a zero-length array, we would return ret unitialized. Patch 0003: If we jum