On Fri, 2012-11-09 at 12:09 +0100, Sumit Bose wrote:
>
> New series attached.
>
ack and pushed to master and 1-9
Simo.
--
Simo Sorce * Red Hat, Inc * New York
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.
On Thu, Nov 08, 2012 at 09:34:19AM -0500, Simo Sorce wrote:
> On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
> >
>
> Can you change the function name to diff_gid_lists() ?
>
>
> Also may be nice to change the following arg names:
> current_gid_count -> cur_gid_num
> current_gids -> cur_gi
On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
> From 64502919dd9dd75b82e2a16808d2c3ed8250a72d Mon Sep 17 00:00:00 2001
> From: Sumit Bose
> Date: Wed, 7 Nov 2012 12:09:55 +0100
> Subject: [PATCH 5/5] Store the original group DN in the subdomain user
> object
>
> For user of the local domai
On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
> From 9bfb75134ede4d6fe335e2492416e974f239008d Mon Sep 17 00:00:00 2001
> From: Sumit Bose
> Date: Wed, 7 Nov 2012 11:53:13 +0100
> Subject: [PATCH 3/5] Use sysdb_initgroups() instead of
> sysdb_get_user_by_name()
>
> To be able to efficientl
On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
> +static errno_t
> +pac_save_memberships_delete(struct pac_save_memberships_state *state)
> +{
[...]
> +for (c = 0; c < pr_ctx->del_gid_count; c++) {
> +ret = sysdb_search_group_by_gid(state,
> state->group_dom->sysdb,
> +
On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
>
> +if (current_gid_count == 0 && gid_count == 0) {
> +ret = EOK;
> +goto done;
> +}
Also noticed that for this condition you probably want to just assign
and return EOK directly, otherwise ...
> +done:
> +
> +if
On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
>
> This patch adds a new call which compares a list of current GIDs with
> a
> list of new GIDs and return a list of GIDs which are currently missing
> and must be added and another list of GIDs which are not used anymore
> and must be deleted.
Hi,
this series of patches fixes https://fedorahosted.org/sssd/ticket/1604 .
To be precise only 0005 is the fix for the ticket, but the others add
some necessary improvements, especially the removal of a group
membership.
bye,
Sumit
From b84d722f4924190265b89dc69b6e3bb46aafb0b3 Mon Sep 17 00:00:0
