Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-30 Thread Stephen Gallagher
On 04/28/2010 01:19 PM, Stephen Gallagher wrote: > Ack. > > On 04/28/2010 01:08 PM, Dmitri Pal wrote: >>> >> Updated patches attached. >> Pushed to master. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.re

Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-28 Thread Stephen Gallagher
Ack. On 04/28/2010 01:08 PM, Dmitri Pal wrote: > Stephen Gallagher wrote: >> On 04/27/2010 12:32 PM, Dmitri Pal wrote: >> >>> Stephen Gallagher wrote: >>> On 04/26/2010 04:38 PM, Dmitri Pal wrote: > Hello, > > Patch 1: New functionality for refarray. Some basic functiona

Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 12:32 PM, Dmitri Pal wrote: > Stephen Gallagher wrote: >> On 04/26/2010 04:38 PM, Dmitri Pal wrote: >> >>> Hello, >>> >>> Patch 1: New functionality for refarray. Some basic functionality was >>> missing. Now it is added. >>> >> >> Nitpick: in ref_array_replace(), your trace message l

Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-27 Thread Dmitri Pal
Stephen Gallagher wrote: > On 04/26/2010 04:38 PM, Dmitri Pal wrote: > >> Hello, >> >> Patch 1: New functionality for refarray. Some basic functionality was >> missing. Now it is added. >> > > Nitpick: in ref_array_replace(), your trace message lists > ref_array_insert(). It might not be

Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-26 Thread Stephen Gallagher
On 04/26/2010 04:38 PM, Dmitri Pal wrote: > Hello, > > Patch 1: New functionality for refarray. Some basic functionality was > missing. Now it is added. Nitpick: in ref_array_replace(), your trace message lists ref_array_insert(). It might not be a bad idea in a separate patch to change TRACE_F