Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/03/2010 07:06 AM, Sumit Bose wrote: >> make distcheck and make rpms are working fine and rpmlint likes the new >> packages. > >> ACK > Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat r

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-03 Thread Sumit Bose
On Tue, Feb 02, 2010 at 07:45:41AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/02/2010 05:50 AM, Sumit Bose wrote: > >> NACK > > > >> libini does not build anymore because it cannot find libcollection. The > >> changes 0006-Split-off-libcollection-i

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-02 Thread Dmitri Pal
Stephen Gallagher wrote: > On 02/02/2010 08:15 AM, Dmitri Pal wrote: > > Are you including trace.h into the library? > > Without it the debug build will be broken. > > It should be a part of the SRPM. > > trace.h is available in the tarball, and its path is still listed in the > AM_CPPFLAGS. > > Th

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-02 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2010 08:15 AM, Dmitri Pal wrote: > > Are you including trace.h into the library? > Without it the debug build will be broken. > It should be a part of the SRPM. trace.h is available in the tarball, and its path is still listed in the AM_CPPF

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-02 Thread Dmitri Pal
Stephen Gallagher wrote: > On 02/01/2010 07:11 PM, Dmitri Pal wrote: > > Stephen Gallagher wrote: > >> Patches 0001-0003: License and package libpath_utils > >> > > 01: In the header should the COPYING.lesser be COPYING.LESSER? > Otherwise Ok. > > I will correct that. > > > 02: Ok > > 03: I can' re

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-02 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2010 05:50 AM, Sumit Bose wrote: >> NACK > >> libini does not build anymore because it cannot find libcollection. The >> changes 0006-Split-off-libcollection-into-a-shared-library.patch does in >> server/ needs to be ported to common/ini/, to

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-02 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/01/2010 07:11 PM, Dmitri Pal wrote: > Stephen Gallagher wrote: >> Patches 0001-0003: License and package libpath_utils >> > 01: In the header should the COPYING.lesser be COPYING.LESSER? Otherwise Ok. I will correct that. > 02: Ok > 03: I can'

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-02 Thread Sumit Bose
On Mon, Feb 01, 2010 at 01:33:27PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Patches 0001-0003: License and package libpath_utils > > Patches 0004-0007: License and package libcollection. (Patch 0005 fixes > an incorrect #include in collection.h) > > P

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-01 Thread Dmitri Pal
Stephen Gallagher wrote: > Patches 0001-0003: License and package libpath_utils > 01: In the header should the COPYING.lesser be COPYING.LESSER? Otherwise Ok. 02: Ok 03: I can' review this file I do not know the RPM syntax yet. > Patches 0004-0007: License and package libcollection. (Patch 0005 fi

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

2010-02-01 Thread Dmitri Pal
Stephen Gallagher wrote: > Patches 0001-0003: License and package libpath_utils > > Patches 0004-0007: License and package libcollection. (Patch 0005 fixes > an incorrect #include in collection.h) > > Patch 0008-0011: License and package libini_config. (Patch 0009 fixes an > array index mistake tha