-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/20/2010 01:17 PM, Stephen Gallagher wrote:
> On 09/20/2010 01:14 PM, Stephen Gallagher wrote:
>> As mentioned in my other email, I've also split sysdb_getnetgr() into
>> two functions. sysdb_getnetgr() will return the ldb_result as retrieved
>> f
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/20/2010 06:46 AM, Sumit Bose wrote:
>> The patches apply fine. There is a whitespace issue, 0001 adds an empty
>> line at the end of sysdb_search.c . All tests passed, please find some
>> comments below.
Fixed.
> ret is undefined
Good catch.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Thanks for the review, Sumit. I will fix these in the next iteration.
I also realized that just returning the final triples won't work, as our
NSS responder code needs other attributes to determine whether the cache
is expired. I'm planning to split t
Jan Zelený wrote:
> Stephen Gallagher wrote:
>
>> On 09/17/2010 07:18 PM, Jan Zeleny wrote:
>>
>>> I went through the code of the first patch and there are some things
>>> which don't seem to be right.
>>>
>>> First of all, the code is missing the memory hierarchy entirely. Here are
>>> so
On Fri, Sep 17, 2010 at 11:21:40AM -0400, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 09/17/2010 11:16 AM, Dmitri Pal wrote:
> > Stephen Gallagher wrote:
> >> On 09/16/2010 05:05 PM, Stephen Gallagher wrote:
> >>> I've rewritten these patches. Now, instead of
Stephen Gallagher wrote:
> On 09/17/2010 07:18 PM, Jan Zeleny wrote:
> > I went through the code of the first patch and there are some things
> > which don't seem to be right.
> >
> > First of all, the code is missing the memory hierarchy entirely. Here are
> > some examples:
> > src/db/sys_ops.c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/17/2010 07:18 PM, Jan Zeleny wrote:
> I went through the code of the first patch and there are some things which
> don't seem to be right.
>
> First of all, the code is missing the memory hierarchy entirely. Here are
> some
> examples:
> src/
Stephen Gallagher wrote:
> On 09/16/2010 05:05 PM, Stephen Gallagher wrote:
> > I've rewritten these patches. Now, instead of searching for individual
> > netgroup entries, the code will take advantage of the memberOf plugin to
> > return all netgroup triples in a single call to sysdb_getnetgr()
>
Stephen Gallagher wrote:
> On 09/17/2010 11:16 AM, Dmitri Pal wrote:
> > Stephen Gallagher wrote:
> >> On 09/16/2010 05:05 PM, Stephen Gallagher wrote:
> >>> I've rewritten these patches. Now, instead of searching for individual
> >>> netgroup entries, the code will take advantage of the memberOf
>
Stephen Gallagher wrote:
> On 09/16/2010 05:05 PM, Stephen Gallagher wrote:
> > I've rewritten these patches. Now, instead of searching for individual
> > netgroup entries, the code will take advantage of the memberOf plugin to
> > return all netgroup triples in a single call to sysdb_getnetgr()
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/15/2010 01:54 PM, Stephen Gallagher wrote:
> On 09/15/2010 11:22 AM, Stephen Gallagher wrote:
>> This is a first pass at the cache storage and retrieval for netgroups
>> information. Part of these patches were written by Jakub, part by me.
>> I'd
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/15/2010 11:22 AM, Stephen Gallagher wrote:
> This is a first pass at the cache storage and retrieval for netgroups
> information. Part of these patches were written by Jakub, part by me.
> I'd prefer it if Jan, Simo or Sumit did the review for th
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
This is a first pass at the cache storage and retrieval for netgroups
information. Part of these patches were written by Jakub, part by me.
I'd prefer it if Jan, Simo or Sumit did the review for this.
I'm going to try to submit patches for review on a
13 matches
Mail list logo
