Re: [SSSD] [PATCHES] Sysdb refactoring

2011-08-15 Thread Stephen Gallagher
On Fri, 2011-08-12 at 10:21 +0200, Jan Zelený wrote: > > On Fri, 2011-07-29 at 15:20 +0200, Jan Zelený wrote: > > > > On 07/29/2011 08:39 AM, Jan Zelený wrote: > > > > >> Considering that it may be a lot of work to regroup the patches, I > > > > >> think > > > > >> > > > > >> > it may be even bett

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-08-12 Thread Jan Zelený
> On Fri, 2011-07-29 at 15:20 +0200, Jan Zelený wrote: > > > On 07/29/2011 08:39 AM, Jan Zelený wrote: > > > >> Considering that it may be a lot of work to regroup the patches, I > > > >> think > > > >> > > > >> > it may be even better to have squash 40-43 and 44-46 together, but > > > >> > a patc

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-08-10 Thread Stephen Gallagher
On Fri, 2011-07-29 at 15:20 +0200, Jan Zelený wrote: > > On 07/29/2011 08:39 AM, Jan Zelený wrote: > > >> Considering that it may be a lot of work to regroup the patches, I think > > >> > > >> > it may be even better to have squash 40-43 and 44-46 together, but a > > >> > patch that does not compi

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-07-29 Thread Jan Zelený
> On 07/29/2011 08:39 AM, Jan Zelený wrote: > >> Considering that it may be a lot of work to regroup the patches, I think > >> > >> > it may be even better to have squash 40-43 and 44-46 together, but a > >> > patch that does not compile seems bad to me. > > > > This sounds reasonable. Should I d

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-07-29 Thread Jakub Hrozek
On 07/29/2011 08:39 AM, Jan Zelený wrote: >> Considering that it may be a lot of work to regroup the patches, I think >> > it may be even better to have squash 40-43 and 44-46 together, but a >> > patch that does not compile seems bad to me. > This sounds reasonable. Should I do the job and send th

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-07-29 Thread Jan Zelený
> On Fri, 2011-07-29 at 08:39 +0200, Jan Zelený wrote: > > > On 07/20/2011 12:58 PM, Jan Zelený wrote: > > > > I'm sending several patches with the sysdb refactoring. Originally, I > > > > was planning one more step - to change return type from int to > > > > errno_t where it was convenient. If som

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-07-29 Thread Stephen Gallagher
On Fri, 2011-07-29 at 08:39 +0200, Jan Zelený wrote: > > On 07/20/2011 12:58 PM, Jan Zelený wrote: > > > I'm sending several patches with the sysdb refactoring. Originally, I was > > > planning one more step - to change return type from int to errno_t where > > > it was convenient. If someone wants

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-07-28 Thread Jan Zelený
> On 07/20/2011 12:58 PM, Jan Zelený wrote: > > I'm sending several patches with the sysdb refactoring. Originally, I was > > planning one more step - to change return type from int to errno_t where > > it was convenient. If someone wants to do it, feel free. Otherwise I'm > > going to make the pat

Re: [SSSD] [PATCHES] Sysdb refactoring

2011-07-28 Thread Jakub Hrozek
On 07/20/2011 12:58 PM, Jan Zelený wrote: > I'm sending several patches with the sysdb refactoring. Originally, I was > planning one more step - to change return type from int to errno_t where it > was convenient. If someone wants to do it, feel free. Otherwise I'm going to > make the patch myse

[SSSD] [PATCHES] Sysdb refactoring

2011-07-20 Thread Jan Zelený
I'm sending several patches with the sysdb refactoring. Originally, I was planning one more step - to change return type from int to errno_t where it was convenient. If someone wants to do it, feel free. Otherwise I'm going to make the patch myself in couple days. When reviewing, please note th