Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-09-05 Thread Jakub Hrozek
On Wed, Sep 04, 2013 at 10:54:55AM +0200, Jakub Hrozek wrote: > On Wed, Sep 04, 2013 at 10:42:43AM +0200, Pavel Březina wrote: > > >Thanks for the review. New weightless patches are attached. > > > > Oops, I didn't save the header file. Another respin is attached. > > > > Also if anyone will ever

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-09-04 Thread Jakub Hrozek
On Wed, Sep 04, 2013 at 10:42:43AM +0200, Pavel Březina wrote: > >Thanks for the review. New weightless patches are attached. > > Oops, I didn't save the header file. Another respin is attached. > > Also if anyone will ever need slinklist implementation, I have it > backed up at: fedorapeople.org

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-09-04 Thread Pavel Březina
On 09/04/2013 10:23 AM, Pavel Březina wrote: On 09/04/2013 10:01 AM, Jakub Hrozek wrote: On Mon, Aug 26, 2013 at 04:26:09PM +0200, Pavel Březina wrote: Yes, I don't have a problem with that. As long as priority and weight are honored. I have done it AD only after all. Enabling it for all prov

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-09-04 Thread Pavel Březina
On 09/04/2013 10:01 AM, Jakub Hrozek wrote: On Mon, Aug 26, 2013 at 04:26:09PM +0200, Pavel Březina wrote: Yes, I don't have a problem with that. As long as priority and weight are honored. I have done it AD only after all. Enabling it for all providers required more changes than expected. I d

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-09-04 Thread Jakub Hrozek
On Mon, Aug 26, 2013 at 04:26:09PM +0200, Pavel Březina wrote: > >Yes, I don't have a problem with that. As long as priority and weight > >are honored. > > I have done it AD only after all. Enabling it for all providers > required more changes than expected. I don't think those changes > should be

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-26 Thread Pavel Březina
On 08/26/2013 12:15 PM, Jakub Hrozek wrote: On Mon, Aug 26, 2013 at 12:08:56PM +0200, Pavel Březina wrote: On 08/23/2013 07:39 PM, Jakub Hrozek wrote: On Fri, Aug 23, 2013 at 07:36:22PM +0200, Pavel Březina wrote: On 08/23/2013 05:44 PM, Jakub Hrozek wrote: On Thu, Aug 08, 2013 at 01:24:17PM

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-26 Thread Jakub Hrozek
On Mon, Aug 26, 2013 at 12:08:56PM +0200, Pavel Březina wrote: > On 08/23/2013 07:39 PM, Jakub Hrozek wrote: > >On Fri, Aug 23, 2013 at 07:36:22PM +0200, Pavel Březina wrote: > >>On 08/23/2013 05:44 PM, Jakub Hrozek wrote: > >>>On Thu, Aug 08, 2013 at 01:24:17PM +0200, Pavel Březina wrote: > On

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-26 Thread Pavel Březina
On 08/23/2013 07:39 PM, Jakub Hrozek wrote: On Fri, Aug 23, 2013 at 07:36:22PM +0200, Pavel Březina wrote: On 08/23/2013 05:44 PM, Jakub Hrozek wrote: On Thu, Aug 08, 2013 at 01:24:17PM +0200, Pavel Březina wrote: On 08/08/2013 03:32 AM, Simo Sorce wrote: On Wed, 2013-08-07 at 13:56 +0200, Lu

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-23 Thread Jakub Hrozek
On Fri, Aug 23, 2013 at 07:36:22PM +0200, Pavel Březina wrote: > On 08/23/2013 05:44 PM, Jakub Hrozek wrote: > >On Thu, Aug 08, 2013 at 01:24:17PM +0200, Pavel Březina wrote: > >>On 08/08/2013 03:32 AM, Simo Sorce wrote: > >>>On Wed, 2013-08-07 at 13:56 +0200, Lukas Slebodnik wrote: > >>>[..] > >>>

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-23 Thread Pavel Březina
On 08/23/2013 05:44 PM, Jakub Hrozek wrote: On Thu, Aug 08, 2013 at 01:24:17PM +0200, Pavel Březina wrote: On 08/08/2013 03:32 AM, Simo Sorce wrote: On Wed, 2013-08-07 at 13:56 +0200, Lukas Slebodnik wrote: [..] nitpicking some more given Lucas nacked. +static errno_t ad_sort_servers(struct a

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-23 Thread Jakub Hrozek
On Thu, Aug 08, 2013 at 01:24:17PM +0200, Pavel Březina wrote: > On 08/08/2013 03:32 AM, Simo Sorce wrote: > >On Wed, 2013-08-07 at 13:56 +0200, Lukas Slebodnik wrote: > >[..] > >nitpicking some more given Lucas nacked. > > > >>>+static errno_t ad_sort_servers(struct ares_srv_reply **list, void *pv

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-08 Thread Pavel Březina
On 08/08/2013 03:32 AM, Simo Sorce wrote: On Wed, 2013-08-07 at 13:56 +0200, Lukas Slebodnik wrote: [..] nitpicking some more given Lucas nacked. +static errno_t ad_sort_servers(struct ares_srv_reply **list, void *pvt) +{ +struct ad_srv_plugin_state *state = NULL; +struct ares_srv_reply

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-08 Thread Pavel Březina
On 08/07/2013 01:56 PM, Lukas Slebodnik wrote: On (06/08/13 14:43), Pavel Březina wrote: On 08/06/2013 10:20 AM, Lukas Slebodnik wrote: On (05/08/13 15:24), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2001 There is a bug in underlying resolv_sort_srv_reply(). It sometimes return

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-07 Thread Simo Sorce
On Wed, 2013-08-07 at 13:56 +0200, Lukas Slebodnik wrote: [..] nitpicking some more given Lucas nacked. > >+static errno_t ad_sort_servers(struct ares_srv_reply **list, void *pvt) > >+{ > >+struct ad_srv_plugin_state *state = NULL; > >+struct ares_srv_reply dummy[3] = {{NULL, NULL, 0, 0, 0

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-07 Thread Lukas Slebodnik
On (06/08/13 14:43), Pavel Březina wrote: >On 08/06/2013 10:20 AM, Lukas Slebodnik wrote: >>On (05/08/13 15:24), Pavel Březina wrote: >>>https://fedorahosted.org/sssd/ticket/2001 >>> >>>There is a bug in underlying resolv_sort_srv_reply(). It sometimes >>>returns less servers than there is on the i

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-06 Thread Pavel Březina
On 08/06/2013 10:20 AM, Lukas Slebodnik wrote: On (05/08/13 15:24), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2001 There is a bug in underlying resolv_sort_srv_reply(). It sometimes returns less servers than there is on the input. This seems to be related to configuration when t

Re: [SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-06 Thread Lukas Slebodnik
On (05/08/13 15:24), Pavel Březina wrote: >https://fedorahosted.org/sssd/ticket/2001 > >There is a bug in underlying resolv_sort_srv_reply(). It sometimes >returns less servers than there is on the input. This seems to be >related to configuration when two servers has the same priority and >weight

[SSSD] [PATCHES] ad srv: prefer servers that are in the same domain as client

2013-08-05 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2001 There is a bug in underlying resolv_sort_srv_reply(). It sometimes returns less servers than there is on the input. This seems to be related to configuration when two servers has the same priority and weight (0). I haven't found the root cause yet, I'l