On Wed, Jan 08, 2014 at 11:27:05AM +0100, Jakub Hrozek wrote:
> On Wed, Jan 08, 2014 at 01:18:58PM +0545, Pallavi Jha wrote:
> > Hi,
> >
> > Thank you for the patch. I checked it and have included the changes in
> > the patch attached with this mail. Please look into it.
>
> ACK
Pushed to master
On Wed, Jan 08, 2014 at 01:18:58PM +0545, Pallavi Jha wrote:
> Hi,
>
> Thank you for the patch. I checked it and have included the changes in
> the patch attached with this mail. Please look into it.
ACK
___
sssd-devel mailing list
sssd-devel@lists.fedo
Hi,
Thank you for the patch. I checked it and have included the changes in
the patch attached with this mail. Please look into it.
From e235241893cf09fbce5fb2f339841dd27ca0dfde Mon Sep 17 00:00:00 2001
From: Pallavi Jha
Date: Wed, 8 Jan 2014 12:41:08 +0545
Subject: [PATCH] cmocka unit test for au
On Wed, Dec 11, 2013 at 03:47:17PM +0545, Pallavi Jha wrote:
> Hello,
>
> Please find the updated patch attached with this mail.
>
> With regards
> Pallavi Kumari Jha
> Computer Science Engineering
Hi Pallavi,
there are still two compilation warnings in the code. Attached is a
patch with changes
Hello,
Please find the updated patch attached with this mail.
With regards
Pallavi Kumari Jha
Computer Science Engineering
On 9 December 2013 19:32, Jakub Hrozek wrote:
> On Sun, Dec 08, 2013 at 01:36:15AM +0545, Pallavi Jha wrote:
> > For your comment
> >
> > I think the checks below are no
On Sun, Dec 08, 2013 at 01:36:15AM +0545, Pallavi Jha wrote:
> For your comment
>
> I think the checks below are not necessary, are they? You already test
> sss_authtok_set with sss_authtok_get_ccfile and also
> sss_authtok_set_ccfile with sss_authtok_get_ccfile.
>
> Maybe I'm not seeing somethi
For your comment
I think the checks below are not necessary, are they? You already test
sss_authtok_set with sss_authtok_get_ccfile and also
sss_authtok_set_ccfile with sss_authtok_get_ccfile.
Maybe I'm not seeing something, but why another sss_authtok_set and
sss_authtok_get_ccfile?
> +ret
Hello Jakub,
Yes sure, will make the required changes and send the patch shortly.
With regards
Pallavi Kumari Jha
Computer Science Engineering
On 19 November 2013 16:06, Jakub Hrozek wrote:
> On Fri, Nov 15, 2013 at 10:44:21PM +0530, Pallavi Jha wrote:
> > Patch with the suggested fix is atta
On Fri, Nov 15, 2013 at 10:44:21PM +0530, Pallavi Jha wrote:
> Patch with the suggested fix is attached along with the mail. Kindly
> review.
Hi Pallavi,
I spotted a couple more places that need fixing, but in overall the test
looks OK and runs fine. Nice job, let's fix the last small issues, see
Patch with the suggested fix is attached along with the mail. Kindly
review.
With regards
Pallavi Kumari Jha
Computer Science Engineering
On 15 November 2013 00:10, Jakub Hrozek wrote:
> On Wed, Nov 13, 2013 at 03:46:38PM +0100, Jakub Hrozek wrote:
> > > +#include "util/authtok.h"
> > > +
> >
On Wed, Nov 13, 2013 at 03:46:38PM +0100, Jakub Hrozek wrote:
> > +#include "util/authtok.h"
> > +
> > +
> > +struct test_state
> > +{
>
> Can you make the above "struct test_state {" ? That would match the
> rest of the SSSD code better..
To clarify further (sorry I missed your ping on the IRC t
On Tue, Nov 12, 2013 at 04:53:23PM +0530, Pallavi Jha wrote:
> Hi,
>
> I have made the required changes in the patch attached with the mail.
> Kindly review it.
>
> With regards
> Pallavi Kumari Jha
> Computer Science Engineering
>
Hi,
this version is much better. I only have a few comments no
Hi,
I have made the required changes in the patch attached with the mail.
Kindly review it.
With regards
Pallavi Kumari Jha
Computer Science Engineering
On 11 November 2013 20:24, Jakub Hrozek wrote:
> On Mon, Nov 11, 2013 at 05:23:04PM +0530, Pallavi Jha wrote:
> > Hello,
> >
> > I am extrem
On Mon, Nov 11, 2013 at 05:23:04PM +0530, Pallavi Jha wrote:
> Hello,
>
> I am extremely sorry for the inconvenience. The patch is attached with the
> mail. Kindly have a look. I will shortly send another patch for authtor
> module with the suggested fix.
>
> Thanking You,
> Pallavi
This code is
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/09/2013 08:59 AM, Pallavi Jha wrote:
> Hi
>
> I have created the patch and attached it with this mail. Kindly
> review it. I have commented some of the test as it fails(gives
> segmentation fault) when authtoken is NULL. I think we should test
>
Hello,
I am extremely sorry for the inconvenience. The patch is attached with the
mail. Kindly have a look. I will shortly send another patch for authtor
module with the suggested fix.
Thanking You,
Pallavi
On 11 November 2013 17:05, Lukas Slebodnik wrote:
> On (09/11/13 19:29), Pallavi Jha wr
On Sat, Nov 09, 2013 at 07:29:46PM +0530, Pallavi Jha wrote:
> Hi
>
> I have created the patch and attached it with this mail.
I don't see any attachment, sorry..
> Kindly review it.
> I have commented some of the test as it fails(gives segmentation fault)
> when authtoken is NULL. I think we sh
On (09/11/13 19:29), Pallavi Jha wrote:
>Hi
>
>I have created the patch and attached it with this mail. Kindly review it.
>I have commented some of the test as it fails(gives segmentation fault)
>when authtoken is NULL. I think we should test tok for NULL before
>accessing its elements. Please corr
Hi
I have created the patch and attached it with this mail. Kindly review it.
I have commented some of the test as it fails(gives segmentation fault)
when authtoken is NULL. I think we should test tok for NULL before
accessing its elements. Please correct me if am wrong.
for example :
uint8_t *s
19 matches
Mail list logo
