[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing lslebodn commented: """ On (07/01/17 08:28), Jakub Hrozek wrote: > >> On 6 Jan 2017, at 16:29, lslebodn wrote: >> >> On (06/01/17 05:52), Jakub Hrozek wrote: >> >This patch is

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ > On 6 Jan 2017, at 16:29, lslebodn wrote: > > On (06/01/17 05:52), Jakub Hrozek wrote: > >This patch is OK, but only for sssd-1-14. In master, we

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ This patch is OK, but only for sssd-1-14. In master, we already fall back to parsing the name string as short name if parsing the qualified name fails. I’m not thrilled about that,

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing lslebodn commented: """ @jhrozek Have you already decided whether it would be better to have this patch or 7b293a5? """ See the full comment at

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ btw I also added a test in PR #113 so that we don't regress again """ See the full comment at https://github.com/SSSD/sssd/pull/109#issuecomment-268489241

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ Thank you, the patch works well. Just please note that after 7b293a5095ef3e63cd2e3f2ff01b7484bf6dcd38 was commited, this patch would only apply for sssd-1-14. That said, I'm not

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing justin-stephenson commented: """ I found that `obj_type` is being provided as an argument to `sssctl_print_object()` and re-worked this PR to take advantage of this. I hope it will be cleaner than

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ Ah, I didn't realize we don't read the objectclass attribute by default. The following hunk should fix it: ``` @@ -219,12 +233,14 @@ static const char

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ Thank you for the patch. Since we already have the full entry object in sysdb_attrs I think it would be better to take a look at the objectclass (`sysdb_attrs_get_string(entry,

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/109#issuecomment-266973055 ___ sssd-devel mailing list --

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/109#issuecomment-266932506 ___

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/109#issuecomment-266932502 ___