[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ Well, I *just* pushed the patches: 0b7ded1..a8191ce That's why I leave the accepted flag for quite some time before pushing..feel free to just remove it next time if you plan on testing patches

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req lslebodn commented: """ The commit "cache_req: add api to create ldb_result from message" broke integration tests: http://sssd-ci.duckdns.org/logs/job/62/01/summary.html The following commit fixed that. IMHO changing

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ On Tue, Feb 07, 2017 at 02:56:00AM -0800, Pavel Březina wrote: > Try now. thanks, that case is now fixed. I'll run a couple of more tests before acking. """ See the full comment at

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req pbrezina commented: """ Try now. """ See the full comment at https://github.com/SSSD/sssd/pull/127#issuecomment-277965152 ___ sssd-devel mailing list --

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ I'm afraid this is still not fixed correctly. Please check this gdb session when I requested an IPA host with a default_domain_suffix pointing to a Windows domain: ``` 0x7f0a1cc0d543 in

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req pbrezina commented: """ > The code looks good to me now but I found one regression - if you set > default_domain_suffix to the AD domain and try to look up a host, the ssh > responder will query the AD domain. Since

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ The code looks good to me now but I found one regression - if you set default_domain_suffix to the AD domain and try to look up a host, the ssh responder will query the AD domain. Since hosts can

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-01 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req pbrezina commented: """ It should be fixed. Thanks. """ See the full comment at https://github.com/SSSD/sssd/pull/127#issuecomment-276646417 ___ sssd-devel mailing list --

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-01-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ There is a bug when looking up keys for a user from a trusted domain: ``` ==3945== Invalid read of size 8 ==3945==at 0x4100FE: sss_dp_callback_destructor (responder_dp.c:61) ==3945==by

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-01-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ I will review this as these changes make the requested changes to the files provider code on review easier. """ See the full comment at