URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
jhrozek commented:
"""
master:
e0903f41922721edf292a9f7e6605a4519db53a1
eaf44bc07dda469a20be07d46737d93f518e2047
"""
See the full comment at
https://github.com/SSSD/sssd/pull/13#issuecomme
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
So, ldap patch passed intg. tests locally.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/13#issuecomment-253782152
___
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
jhrozek commented:
"""
yes, if we don't know how to trigger the code, we shouldn't push it.
OK to push the two commits now?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/1
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
lslebodn commented:
"""
On (14/10/16 04:48), celestian wrote:
>I did manual testing with reproducer above. And I ran chmake (it is without
>intg., isn't it).
>Now I check ldap patch with in
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
I did manual testing with reproducer above. And I ran chmake (it is without
intg., isn't it).
Now I check ldap patch with intg.
"""
See the full comment at
https:
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
lslebodn commented:
"""
On (14/10/16 04:33), Jakub Hrozek wrote:
>btw since the memberof patch we couldn't test is gone, I'm fine with pushing
>these two.
>
I would like to know Petr's expl
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
jhrozek commented:
"""
btw since the memberof patch we couldn't test is gone, I'm fine with pushing
these two.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/13#issuecommen
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
lslebodn commented:
"""
> Great, the result is the same. Both patches could fix it. So we can use just
> ldap patch.
What do you mean by both patches could fix it?
I aplied just a memboer
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
lslebodn commented:
"""
> Great, the result is the same. Both patches could fix it. So we can use just
> ldap patch.
What do you mean by both patches could fix it?
I aplied just a memboero
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
Great, the result is the same. Both patches could fix it. So we can use just
ldap patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/13#issuecom
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
Oh no, I tested it for ldap, not for ipa provider. Wait a minute a will test it
again. :-(
"""
See the full comment at
https://github.com/SSSD/sssd/pull/13#issuec
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
I changed the author of ldap patch to @sumit-bose.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/13#issuecomment-253734041
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
fidencio commented:
"""
On Fri, Oct 14, 2016 at 9:46 AM, celestian wrote:
> So, I looked this patch set again. Both, ldap and memberof patch, can fix
> the issue itself. I removed memberof
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
So, I looked this patch set again. Both, ldap and memberof patch, can fix the
issue itself. I removed memberof patch.
Original author of ldap patch is @sumit-bose
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
jhrozek commented:
"""
So I wanted to write a test for the memberof patch, but I couldn't reproduce
the ticket #2940 even without the memberof patch. I tried exactly the steps in
the ticke
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
jhrozek commented:
"""
I think :@lslebodn is right, because I removed just the memberof patch. Now I
have:
```
ab6dee1 TESTS: Adding intg. tests on nested groups
257b66a LDAP: Removing of m
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
At first I would like to inform that ticket:
https://fedorahosted.org/sssd/ticket/3186 wasn't bug. This patch is valid for
ldap provider too. (I tested again manua
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
lslebodn commented:
"""
Downstream related tests passed.
So +1
However, it seems that patch
"MEMBEROF: Don't resolve members if they are removed"
is not covered by integration test in 3rd p
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
lslebodn commented:
"""
On (21/09/16 02:18), Jakub Hrozek wrote:
>I think all review requests were addressed, the code now looks good to me and
>just reverting the non-code changes make the
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
jhrozek commented:
"""
I think all review requests were addressed, the code now looks good to me and
just reverting the non-code changes make the tests fail.
So I'm adding the Accepted lab
URL: https://github.com/SSSD/sssd/pull/13
Title: #13: MEMBEROF: Don't resolve members if they are removed
celestian commented:
"""
Hello,
I pushed new version with tests.
Thanks @sumit-bose with help with the second patch. By the way is there better
way how to write co-authors? Please tell me.
21 matches
Mail list logo
