URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
@jhrozek, patch set has been updated.
Now it also checks the confdb in order to now what we should do.
Please, give it a try, all the issues you have seen should be resolved.
In case some
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
@jhrozek, patch set has been updated.
Now it also checks the confdb in order to now what we should do.
Please, give it a try, all the issues you have seen should be resolved.
In case some
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
jhrozek commented:
"""
I still found two issues:
- with no sssd.conf, the nss service is still enabled in confdb, so it's
started by the monitor and then also the socket-activated service is started
- for some r
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
Fair enough. I'm adding accepted label.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuecomment-414299547
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
@pbrezina, I totally agree and the steps described can be taken as a
continuation of my patch.
I'd like to:
- Have my patch merged;
- Have a bug opened with your proposal;
So, any contribu
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
That being said, I do not oppose your work Fabiano, it would be used in that
case as well.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuecomment-414269114
___
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
OK. It was not related. Patches works as expected so ACK to the patches but...
Services that are enabled through sssd.conf yields the following warning, which
is correct:
```
[root /var/li
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
This sounds better. I'm having some issues when testing this patch, but it may
be unrelated. I will let you know later.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#i
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
```
[ffidenci@pessoa sssd]$ git diff
diff --git a/src/tools/sssd_check_socket_activated_responders.c
b/src/tools/sssd_check_socket_activated_responders.c
index e83de622b..0b1a4df94 100644
-
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
@pbrezina: what I tried to say is that sssd.service has a
Wants=sssd-@responder.socket, which will make the sssd-@responder.socket to be
started as soon as sssd.service is started ... rely
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
I don't really understand this line:
```
+"However, SSSD automatically pulls in the \"%s\" socket(s) and
"
+"relies on systemd to start and manage the respo
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
Patch set has been updated and is ready for review.
I'm also removing the "postponing until sssd 2.0" label.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuecomment-
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
OK. In that case the manpage change should be rephrase because the term `all
services` is misleading.
```
By default, all services are enabled.
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
Yes, they are. Theoretically sssd and kcm responders' sockets are (or should
be) enabled by default by the distro.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuec
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
Yes, they are. Theoretically secrets and kcm responders' sockets are (or should
be) enabled by default by the distro.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#iss
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
Sockets for secrets and kcm responders are avoided on purpose?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuecomment-411698413
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
Just rebased atop of git master.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuecomment-44188
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/61/27/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuecomment-274844018
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
lslebodn commented:
"""
BTW the second patch had to be also removed because required functions were in
newer versions of systemd which are not in CentOS
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
The patch changes the current logic of having the services' sockets disabled by
default as it adds a "Wants=" to the sssd unit file, making all the services'
sockets enabled by the moment
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit and avoid PAC responder to be always
running
lslebodn commented:
"""
On (24/01/17 02:58), fidencio wrote:
>@lslebodn:
>Okay, you don't agree with the second patch and I'm totally fine about that
>(in case other d
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit and avoid PAC responder to be always
running
fidencio commented:
"""
@lslebodn:
Okay, you don't agree with the second patch and I'm totally fine about that (in
case other developers don't agree as well). So, we c
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit and avoid PAC responder to be always
running
lslebodn commented:
"""
I am sorry I do not agree with such solution.
As I wrote few times on IRC. We should simplify monitor code and not add new
code there.
"""
See
23 matches
Mail list logo