[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-13 Thread lslebodn
lslebodn commented on a pull request """ On (13/09/16 06:07), sumit-bose wrote: >I think it is still an ACK. > master: * d3348f49260998880bb7cd3b2fb72d562b1b7a64 LS """ See the full comment at https://github.com/SSSD/sssd/pull/15#issuecomment-246680797 _

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-13 Thread sumit-bose
sumit-bose commented on a pull request """ I think it is still an ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/15#issuecomment-246674999 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-13 Thread lslebodn
lslebodn commented on a pull request """ On (07/09/16 10:13), Jakub Hrozek wrote: >On Tue, Sep 06, 2016 at 06:09:58AM -0700, Jakub Hrozek wrote: >> good idea > >ah, only when I started to implement this I realized it's already done :) > >See: > > https://github.com/SSSD/sssd/blob/master/src/pr

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 06:09:58AM -0700, Jakub Hrozek wrote: > good idea ah, only when I started to implement this I realized it's already done :) See: https://github.com/SSSD/sssd/blob/master/src/providers/krb5/krb5_child.c#L1364 in the current mast

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread jhrozek
jhrozek commented on a pull request """ good idea """ See the full comment at https://github.com/SSSD/sssd/pull/15#issuecomment-244944667 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-deve

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread sumit-bose
sumit-bose commented on a pull request """ On Tue, Sep 06, 2016 at 04:51:26AM -0700, Jakub Hrozek wrote: > Thanks for the ack, I would also like to ask @sumit-bose if he agrees with > the change. Since we already handle other clock skew related error codes the same way I think it is ok. But I wo

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread sumit-bose
sumit-bose commented on a pull request """ On Tue, Sep 06, 2016 at 05:37:14AM -0700, Pavel Březina wrote: > On 09/06/2016 02:21 PM, Jakub Hrozek wrote: > > On Tue, Sep 06, 2016 at 05:10:07AM -0700, Pavel Březina wrote: > > > On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > > > > Thanks for the ack,

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread pbrezina
pbrezina commented on a pull request """ On 09/06/2016 02:21 PM, Jakub Hrozek wrote: > On Tue, Sep 06, 2016 at 05:10:07AM -0700, Pavel Březina wrote: > > On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > > > Thanks for the ack, I would also like to ask @sumit-bose > > >

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 05:10:07AM -0700, Pavel Březina wrote: > On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > > Thanks for the ack, I would also like to ask @sumit-bose > > if he agrees with the change. > > Btw since clock s

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread pbrezina
pbrezina commented on a pull request """ On 09/06/2016 01:51 PM, Jakub Hrozek wrote: > Thanks for the ack, I would also like to ask @sumit-bose > if he agrees with the change. Btw since clock skew is not fatal anymore, is it possible for us to actually perform onl

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread jhrozek
jhrozek commented on a pull request """ Thanks for the ack, I would also like to ask @sumit-bose if he agrees with the change. """ See the full comment at https://github.com/SSSD/sssd/pull/15#issuecomment-244927163 ___ sssd-devel mailing list sssd-dev