URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
jhrozek commented:
"""
606015a4f71d8ee809347188667d268f73110483
8bb6680637ead03e24a38d15ec5265d11a920a1d
9286d0d4143bcb4e36b91022107e307998122bbb
7cd226414c7bcdd32f05416df64ebda3ac869bd7
828fe7528fbe6971701d16aed87ba12
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
jhrozek commented:
"""
I knew there's a reason for me to send a CI as well, because mine passed :-)
http://sssd-ci.duckdns.org/logs/job/64/74/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pul
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
fidencio commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/64/75/summary.html
There's a failure on f25 mock build but it's not related to this series.
"""
See the full comment at
https://github.com/SSSD/sssd/pu
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/154#issuecomment-286352432
___
sssd-devel mailing list -- sssd-devel
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
jhrozek commented:
"""
oops, I also submitted to the internal CI, I guess more checks don't hurt. let
me reschedule the centos CI though to see if there was just a fluke
"""
See the full comment at
https://github.co
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
fidencio commented:
"""
I'm running our internal CI and I'll post the link when it passes.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/154#issuecomment-286351873
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
fidencio commented:
"""
@jhrozek, pushed a new version.
Here's the diff in order to make your review easier:
```
diff --git a/src/confdb/confdb.h b/src/confdb/confdb.h
index 6e54b72..c05b1ce 100644
--- a/src/confdb/c
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
jhrozek commented:
"""
I vote for `cache_first` :)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/154#issuecomment-286345259
___
sssd-devel mailing list -- s
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
fidencio commented:
"""
@jhrozek: make your choice and I'll do the sed
"""
See the full comment at
https://github.com/SSSD/sssd/pull/154#issuecomment-286277686
___
sssd-dev
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
justin-stephenson commented:
"""
I agree with that the term `confront caches` sounds a bit unusual, perhaps
something like `cache_first`, `cache_direct`, or `direct_to_cache` may be more
clear.
"""
See the full comm
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
justin-stephenson commented:
"""
I agree with that the term `confront caches` sounds a bit unusual, perhaps
something like `cache_first`, `cache_direct`, or `direct_to_cache` may be more
clear.
"""
See the full comm
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
jhrozek commented:
"""
I'm sorry I have one more question before pushing the patches. Could we please
ask some native English speaker if the "confront_caches" option sounds good to
them? To me it sounds a bit strange
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
pbrezina commented:
"""
Ack. Thank you for your patience.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/154#issuecomment-286064545
___
sssd-devel mailing li
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
fidencio commented:
"""
Pavel,
I've taken your patches, reworked in order to have then sorted out in a way
that makes sense and have pushed a new series.
Some changes have been done in order to have them working pro
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
pbrezina commented:
"""
Hi, thank you. This version looks much better. There where few logic issues in
the code, I started to write the review but then I had a need to actually try
to code my suggestions to see if it
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
fidencio commented:
"""
@pbrezina:
Patch set update. I've tried to address all your comments.
I'm removing the "Changes request" label.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/154#issuecomment-
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
pbrezina commented:
"""
Hi, this version looks much better. `cache_req: cinfront caches first` has some
smaller issues that will be easily fix. Let's focus on the first patch to get
the tevent request good and then w
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
fidencio commented:
"""
@pbrezina:
So, firstly sorry for the long time taken for updating this PR. I've been
slapped in the face by tevent when trying to have a code reasonable clean.
So, the first patch* moves the i
URL: https://github.com/SSSD/sssd/pull/154
Title: #154: Confront caches first
pbrezina commented:
"""
Hi, thank you for the patch.
```c
@@ -469,6 +476,8 @@ static void cache_req_input_parsed(struct tevent_req
*subreq)
return;
}
+cache_req_setup_search_approach(state);
+
19 matches
Mail list logo
