URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
jhrozek commented:
"""
* master:
* c44728a02d5e2c9eaced11e74820a6ae6a985f61
* 49f8ec8e0a3723a748bdb043d6dc1fb2a3977a8a
* b341ee51cffd98b642b9c68a417f8a7504e303a1
* 81c564a0692aa4b719af2219f52894e6cd4bdf9f
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
sumit-bose commented:
"""
Hi Lukas, thank you for your patches, I included both of them in the latest
versions.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/192#issuecomment-288753675
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
lslebodn commented:
"""
And there are few missing header files when compiling with libcrypto.
diff:
https://paste.fedoraproject.org/paste/MlrGzY73CqDliU5zYUZOYV5M1UNdIGYhyRLivL9gydE=/
"""
See the full commen
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
lslebodn commented:
"""
And there are few missing heaker files when compiling with libcrypto.
diff:
https://paste.fedoraproject.org/paste/MlrGzY73CqDliU5zYUZOYV5M1UNdIGYhyRLivL9gydE=/
"""
See the full commen
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
lslebodn commented:
"""
And there are few missing heaker files when compiling with libcrypto.
diff:
https://paste.fedoraproject.org/paste/MlrGzY73CqDliU5zYUZOYV5M1UNdIGYhyRLivL9gydE=/
"""
See the full commen
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
jhrozek commented:
"""
btw the bug with the D-Bus lookups is fixed with the new version.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/192#issuecomment-288650346
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
jhrozek commented:
"""
Thank you, the patches now look good to me. I'm only waiting for the CI run
before the final ACK, but it should be noted again that the review was mostly
based on reading the code and
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
sumit-bose commented:
"""
Thank you for the review, the new versions also contains a fix for the default
matching rule which we discussed on irc.
"""
See the full comment at
https://github.com/SSSD/sssd/pu
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
jhrozek commented:
"""
I won't pretend I read the certmap library code carefully, I more or less
checked the API, ran the tests and scrolled through the library code. My only
concern there is the memory all
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
lslebodn commented:
"""
On (21/03/17 08:59), Jakub Hrozek wrote:
>jhrozek commented on this pull request.
>> +src/util/crypto/nss/nss_base64.c \
>+src/util/cert/nss/cert.c \
>+src/util/crypto/nss/
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
sumit-bose commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/192#issuecomment-286989252
___
sssd-devel mailing list
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
sumit-bose commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/192#issuecomment-286795274
___
sssd-devel mailing list
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
sumit-bose commented:
"""
Hi,
Lukas, thank you for the review. I fixed the invalid read the two NULL RETURNS,
the PW.SET_BUT_NOT_USED and the CLANG WARNING.
It would be possible to save the result in a var
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
lslebodn commented:
"""
There is a valgring error in unit test.
```
==11568== Invalid read of size 1
==11568==at 0x4C32CC4: strcmp (vg_replace_strmem.c:842)
==11568==by 0x50412EA: _assert_string_equal
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
sumit-bose commented:
"""
oops, I'm sorry, I'm really sure I did run 'make distcheck' before sending the
PR.
The library be used by IPA https://github.com/freeipa/freeipa/pull/575.
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
lslebodn commented:
"""
Which library/project will be an external consument of `libsss_certmap.so` ?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/192#issuecomment-286092280
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
lslebodn commented:
"""
There are few missing files:
* xml for man page `sss-certmap.5`
* src/lib/certmap/sss_certmap_attr_names.c
`make[2]: *** No rule to make target
'src/lib/certmap/sss_certmap_attr_names
17 matches
Mail list logo
