URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
Pushed to master:
* e89ba95737202d551db2c9524127e6c4cf308796
* 2b5518eeaacc6245cfa77ee4a7086f16208060fc
* 35c9dfe9ba78d3a635cd1af0fb6349ba44344623
* cac0db2f8004ae88b9263dc3888a11a2d3d3d114
*
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
OK, hopefully final CI run:
http://sssd-ci.duckdns.org/logs/job/65/48/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-289083382
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
lslebodn commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-289045128
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I also squashed Lukas' patch to fix some python3 issues. I'm just waiting for
our CI to finish.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-289036591
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
@lslebodn I pushed a new patchset that should fix the warning in the kcm_queue
test, can you verify if all warnings you saw are fixed?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
simo5 commented:
"""
All looks good to go.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-289009240
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
All my concerns have been addressed (and If I am not mistaken also Simo's). ACK
from me.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288987732
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
CI on the rebased patches:
http://sssd-ci.duckdns.org/logs/job/65/45/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288949515
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
rebased on master
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288860242
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I pushed new patches. CI passed:
http://sssd-ci.duckdns.org/logs/job/65/29/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288756506
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
Thank you for the testing and the review, I hope I addressed all comments.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288486811
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Some nitpicks mostly regarding the lack of DEBUG messages.
src/responder/kcm/kcmsrv_cmd.c
164 /* First 16 bits are 8 bit major and 8bit major protocol version */
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Other then that it LGTM and what I tried worked for me.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288409819
___
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Other than that it LGTM and what I tried worked for me.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288409819
___
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Some nitpicks mostly regarding the lack of DEBUG messages.
src/responder/kcm/kcmsrv_cmd.c
164 /* First 16 bits are 8 bit major and 8bit major protocol version */
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/65/17/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288347513
___
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I also removed the declaration of sss_krb5_marshal_creds which was a leftover
from parsing the creds (which is something I have in a different branch until
we need to renew credentials..)
"""
See the
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I made two fixes related to documentation and packaging. They are already
squashed, but to ease the review, the documentation fix was:
```
diff --git a/src/man/sssd-kcm.8.xml b/src/man/sssd-kcm.8.xml
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
On Tue, Mar 21, 2017 at 10:31:10AM -0700, mzidek-rh wrote:
> Nitpick: In the contrib/kcm_default_ccache it would be good to indicate (in
> the comments) where the snippet belongs.
Done.
> It is
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Nitpick: In the contrib/kcm_default_ccache it would be good to indicate (in the
comments) where the snippet belongs. It is written in the commit message, but
if someone just opens the file he/she
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
On Tue, Mar 21, 2017 at 09:26:23AM -0700, mzidek-rh wrote:
> Actually we do check for libcurl in configure. The reproducer is:
>
>
> $ sudo dnf remove libcurl-devel
> $ configure | grep curl
>
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Actually we do check for libcurl in configure. The reproducer is:
$ sudo dnf remove libcurl-devel
$ configure | grep curl
configure: WARNING:
The libcurl development library was not found. Some
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
On VM with were libcurl-devel is not installed, the configure succeeds, but
compilation fails with:
/home/user/gitrepo/sssd/src/util/tev_curl.c:32:23: fatal error: curl/curl.h: No
such file or
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
On VM with were libcurl-devel is not installed, the configure succeeds, but
compilation fails with:
/home/user/gitrepo/sssd/src/util/tev_curl.c:32:23: fatal error: curl/curl.h: No
such file or
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I pushed new patches that implement what Simo asked for:
* the kcm_ops module now queues all requests from the same UID
* the secrets module does no special casing of the KCM paths
* the KCM data is
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
also remove all the KCM-specific knowledge from sssd-secrets, like the
session/peristent checks.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-287810557
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
also, store the ccaches at cn=kcm not at cn=ccaches
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-287805107
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I had an IRC discussion with @simo5 about the patches and he requested some
changes:
* don't special case /kcm in the routing protocol and allow routing KCM to
Custodia
* serialize write operations
28 matches
Mail list logo
