URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
http://sssd-ci.duckdns.org/logs/job/66/78/summary.html
master:
* dc186bfe90665c13d589b3b4efd9009293e62c46
* 18e4fe9d836e8f7bee52724374ffc0011172329f
* 13d720de13e490850c1139e
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
http://sssd-ci.duckdns.org/logs/job/66/78/summary.html
master:
* dc186bfe90665c13d589b3b4efd9009293e62c46
* 18e4fe9d836e8f7bee52724374ffc0011172329f
* 13d720de13e490850c1139e
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
I changed `POST` method from `CURLOPT_POST` to `CURLOPT_CUSTOMREQUEST = "POST"`
since it the first option uses different options to pass data and data length
to curl. Now it
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
There is still the same problem on rhel7 even with the latest version
```
(gdb) l 563
558 return;
559 }
560
561 len = http_parser_execute(&prctx->
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
rhel7 error
```
test_secrets.py::test_crd_ops PASSED
test_secrets.py::test_curlwrap_crd_ops FAILED
test_secrets.py::test_curlwrap_parallel PASSED
test_secrets.py::test_contain
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
We should skip secrets test on rhel6.
So the patch "ci: do not build secrets on rhel6" should also contain
```
diff --git a/src/tests/intg/test_secrets.py b/src/tests/intg/te
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
I fixed the hang. It was created due to newly added test in KCM patches that
uses POST to create a container. Tcurl test tool can provide body to POST
operation which was ma
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
I'm going to run CI before pushing these patches.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/198#issuecomment-290040911
__
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
On Wed, Mar 29, 2017 at 12:29:27AM -0700, lslebodn wrote:
> BTW the 1st patch "tcurl: add support for ssl and raw output" caused a hang
> in test_secrets and therefore interna
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
BTW the 1st patch "tcurl: add support for ssl and raw output" caused a hang in
test_secrets and therefore internal CI was blocked whole night. The 2nd patch
"tcurl test: ref
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
hmm, it still fails with rhel{6,7}.
http://sssd-ci.duckdns.org/logs/job/66/07/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/198#issuecomment-28
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
Ok, I switched order of patches and added two more:
* ci: do not build secrets on rhel6 -- this should suppress building secrets on
rhel6
* sss_iobuf: fix 'read' shadows a gl
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
On (28/03/17 02:48), Pavel Březina wrote:
>I fixed simo's comments.
>
>The compilation issue on RHEL7 is fixed simple by removing the argument --
>give it's only a test tool
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
I fixed simo's comments.
The compilation issue on RHEL7 is fixed simple by removing the argument -- give
it's only a test tool I don't think it is worth spending time implem
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
Build failed on rehl6 and rhel7
http://sssd-ci.duckdns.org/logs/job/65/71/summary.html
rhel7
```
make-tests
/var/lib/jenkins/workspace/ci/label/rhel7/src/tests/tcurl_test_too
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/198#issuecomment-289439821
___
sssd-devel mailin
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
Just for the record. Crash was caused by setting `long` value into variable
`response_code` which had type `int`. And variables `req` and `response_code`
were on the stack n
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
I can reproduce crash on my local machine
```
$./tcurl-test-tool --debug 9 -v -s
/tmp/sssd-intg.mv9upf1l/var/run/secrets.socket 'http://localhost/secrets/foo'
(Thu Mar 23 16:
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
On 03/22/2017 10:09 AM, Jakub Hrozek wrote:
> Looks like the curl version on RHEL-7 is too old to support some features:
>
> |/var/lib/jenkins/workspace/ci/label/rhel7/src/uti
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
About the missing Content-Lenght, did you check with @tiran if this is a bug in
Custodia?
Finally, I'm conflicted if we need to allow the options to disable peer
verificatio
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
I think you need to make libcurl detection not optional, but required if sssd
is build with sssd-secrets to avoid errors like:
```
/builddir/build/BUILD/sssd-1.15.3/src/util/t
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
Looks like the CI tests fail even on fedora..:
```
=== FAILURES ===
test_curlwrap_c
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
Looks like the curl version on RHEL-7 is too old to support some features:
```
/var/lib/jenkins/workspace/ci/label/rhel7/src/util/tev_curl.c: In function
'curl_code2errno':
/v
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
lslebodn commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/198#issuecomment-287043707
___
sssd-devel mailin
24 matches
Mail list logo
