[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations jhrozek commented: """ * master: * cd83aead3c9799ac05d8f8977dbb92bbd399c6d5 * a04bef313508c423ed06cc54805a3b8106ab90cd """ See the full comment at https://github.com/SSSD/sssd/pull/203#i

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-23 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations sumit-bose commented: """ Thank you, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/203#issuecomment-288756475 ___ sssd-devel

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-23 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations justin-stephenson commented: """ PR updated, thanks again for the quick feedback. """ See the full comment at https://github.com/SSSD/sssd/pull/203#issuecomment-288692791 _

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-22 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations justin-stephenson commented: """ Thank you Sumit and Lukas for the review, changes made as requested. """ See the full comment at https://github.com/SSSD/sssd/pull/203#issuecomment-2884521

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations sumit-bose commented: """ Besides the review comments the patch looks good and is working as expected. """ See the full comment at https://github.com/SSSD/sssd/pull/203#issuecomment-288387

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-20 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations justin-stephenson commented: """ PR updated, sorry I wasn't sure what the proper place to add the `ipa_s2n_reqtype2str` function. I am happy to move it elsewhere if needed. """ See the ful

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-20 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations justin-stephenson commented: """ PR updated, sorry I wasn't sure what the proper place to add the `ipa_s2n_reqtype2str` function. I am happy to move it elsewhere if needed. """ See the ful

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-17 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations justin-stephenson commented: """ Agreed, I think that will be more useful. I will update this PR to implement this. """ See the full comment at https://github.com/SSSD/sssd/pull/203#issue

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations sumit-bose commented: """ Thank you for the patch. What do you think about adding a translation call like be_reg2str() to not only show the request by number? """ See the full comment at

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations sumit-bose commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/203#issuecomment-287178642 ___ sssd-devel mai

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-16 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/203#issuecomment-287174617 _

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-16 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/203#issuecomment-287174614 _