URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
jhrozek commented:
"""
* master:
59db26782d052ddbec633279d08e8627ca57fd41
e3d9ce0ac22796cb08ad2daed006021b44b28c69
4c508463be960682cf94b4e5a39be2f8f49067c8
a5e9d34fd39c0061ca284674a6fd7cad05c6056c
9a44e78
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
lslebodn commented:
"""
@jhrozek LGTM. I would appreciate more unit test for corner cases but that can
be done later.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-3271
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
jhrozek commented:
"""
ACK from me after the changes. The last patch now introduces a slight change in
behaviour in the sense that the DN was not sanitized, but I would call that a
fix :-)
Adding accep
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
@lslebodn, patch set has been updated!
Please, if there's still something that you don't agree, feel free to just push
directly to my branch during the time I'll be off.
"""
See
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
@lslebodn, you're right. We do sanitize the dn before passing to both
functions. I'll update the patches soon, thanks for noticing this.
"""
See the full comment at
https://gith
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
lslebodn commented:
"""
BTW 1st part of commit tile is usually component (e.g. IPA/AD/SDAP/LDAP/SYSDB
...) and not C file.
But it is not a blocker if it will not be changed.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
lslebodn commented:
"""
I noticed that we sanitize DN on few places before passing it to
`sysdb_search_groups_by_orig_dn`.
I thing we should not rely on caller function and sanitize it within
`sysdb_sea
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
jhrozek commented:
"""
CI: http://vm-058-233.XXX/logs/job/74/95/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-326501909
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
Added a simple patch with tests!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-326353798
___
sssd-dev
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
Okay. I'll write the tests and update the patch set (if not Tomorrow, in a week
or so),
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-326335150
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
jhrozek commented:
"""
btw functional testing passed. I couldn't resolve supplemental groups of AD
users at one point, but I couldn't reproduce it afterwards and because I do all
my testing on a single
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
jhrozek commented:
"""
And additionally, a new function calls for a unit test in the sysdb tests..
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-326320682
__
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
jhrozek commented:
"""
Actually, I also missed this previously:
```
/sssd/src/db/sysdb_ops.c: In function ‘sysdb_search_by_orig_dn’:
/sssd/src/db/sysdb_ops.c:3265:20: warning: unused variable ‘basedn’
[-
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
Patch set has been updated.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-318327223
___
sssd-devel ma
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
This patchset introduced a few issues in our integration tests. As they're not
high prio I'm adding "Changes requested" label and will revisit those later on
...
"""
See the ful
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
This patchset has **no priority** and does **not** need a quick review!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-307026134
_
16 matches
Mail list logo
