URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
jhrozek commented:
"""
* master: dcdf292567d50e5cc527766c1944dcf6a8ecacc5
"""
See the full comment at
https://github.com/SSSD/sssd/pull/31#issuecomment-252583002
URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
jhrozek commented:
"""
On Mon, Oct 10, 2016 at 01:07:12AM -0700, sumit-bose wrote:
> On Fri, Oct 07, 2016 at 08:21:21AM -0700, Jakub Hrozek wrote:
> > I'm afraid Coverity
URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
sumit-bose commented:
"""
On Fri, Oct 07, 2016 at 08:21:21AM -0700, Jakub Hrozek wrote:
> I'm afraid Coverity found something it doesn't like:
> ```
The latest patch should
URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
jhrozek commented:
"""
I'm afraid Coverity found something it doesn't like:
```
Error: COMPILER_WARNING:
sssd-1.14.2/src/responder/nss/nsssrv_cmd.c: scope_hint: In function
URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
jhrozek commented:
"""
ACK. I will push the patch once Coverity finishes.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/31#issuecomment-252280250
URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
jhrozek commented:
"""
On Mon, Sep 26, 2016 at 02:43:03AM -0700, sumit-bose wrote:
> On Mon, Sep 26, 2016 at 02:13:08AM -0700, Jakub Hrozek wrote:
> > jhrozek commented on
URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
sumit-bose commented:
"""
On Mon, Sep 26, 2016 at 02:13:08AM -0700, Jakub Hrozek wrote:
> jhrozek commented on this pull request.
>
>
>
> > if (name == NULL) {
URL: https://github.com/SSSD/sssd/pull/31
Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME
jhrozek commented:
"""
I'm sorry the review took so long.
The patch mostly looks good, but see the two questions though the github review
tool. I also wrote some tests, so
