[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-06 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ master: * 2e72ababbbadda4c4036f99528460c1d595e0941 """ See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327452904 __

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-06 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327450226 ___ sssd-devel maili

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-06 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ On (06/09/17 00:49), Pavel Březina wrote: >I don't see `ORIGINALAD_PREFIX SYSDB_NAME` here... > Nice catch. i have no idea where I found `ORIGINALAD_PREFIX ...

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-06 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ ```c const char * sss_get_name_from_msg(struct sss_domain_info *domain, struct ldb_message *msg) { const char *name; /* If domain

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ >But why should it be needed in cache_req_search_ncache_filter where it isn't >used? I guess I'm missing something. It is not directly used by `cache_req_sear

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ But why should it be needed in `cache_req_search_ncache_filter` where it isn't used? I guess I'm missing something. """ See the full comment at https://githu

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid sumit-bose commented: """ The ORIGINALAD_PREFIX SYSDB_NAME is needed for sid_to_name requests. Sorry, I haven't check if the sid_to_name code-patch is involed here. """ See the full

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ These attributes are consumed by `sss_get_name_from_msg` called from `cache_req_search_ncache_filter`. This function returns the name in the following order:

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ sorry for long response. I'll provide intg test soon in PR. It needn't block this bug fix. """ See the full comment at https://github.com/SSSD/sssd/pull/351#

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-08-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid jhrozek commented: """ Setting Changes requested as per @pbrezina's last comment (note that this is NOT a nudge for anyone to work faster, I'm just reconciling the PR statuses) """

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-08-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ Since we depend on name attribute here, we should make it part of default attributes that are merged to the requested attributes in `cache_req_data_create_att

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-08-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ On (21/08/17 03:11), fidencio wrote: >@lslebodn ... seems that nss_cmd_getsidbyid() is the only function using >object_by_id(). > >Knowing that, I'd also sugge

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-08-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ On (21/08/17 03:11), fidencio wrote: >@lslebodn ... seems that nss_cmd_getsidbyid() is the only function using >object_by_id(). > >Knowing that, I'd also sugge

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-08-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid fidencio commented: """ @lslebodn ... seems that nss_cmd_getsidbyid() is the only function using object_by_id(). Knowing that, I'd also suggest to take a look at responder/common/ca

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-08-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ Another solution would be soften requirement for attribute NAME in `cache_req_search_ncache_filter` @pbrezina what do you think :-) """ See the full comment